[SPARK-45990][SPARK-45987][PYTHON][CONNECT] Upgrade protobuf to 4.25.1 to support Python 3.11#43885
[SPARK-45990][SPARK-45987][PYTHON][CONNECT] Upgrade protobuf to 4.25.1 to support Python 3.11#43885dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
protobuf to 4.25.1 to support Python 3.11#43885Conversation
…5.1 to support `Python 3.11`
|
cc @grundprinzip and @HyukjinKwon |
| grpcio>=1.48,<1.57 | ||
| grpcio-status>=1.48,<1.57 | ||
| protobuf==3.20.3 | ||
| protobuf==4.25.1 |
There was a problem hiding this comment.
Hmmm.. I remember we set this protobuf to 3.X because of some compat problem ... do you remember @grundprinzip ?
There was a problem hiding this comment.
If then, we may need to drop Python 3.11 support officially from Spark Connect module.
There was a problem hiding this comment.
We had better match the server and client via 4.25.1 from Apache Spark 4.0.0. Otherwise, it's difficult to support Python 3.11 and Python 3.12 and more.
|
WDYT about upgrade Java part too in this PR, @grundprinzip and @HyukjinKwon ? |
HyukjinKwon
left a comment
There was a problem hiding this comment.
I'm good with this change. I just vaguely remember that there was a compat problem so would defer to @grundprinzip though.
|
I'm fine with upgrading Java side too @hvanhovell but I don't have a very good insight about compat. I'll cc you Herman here too. |
|
Oh btw should probably regen the python protobuf code (https://github.com/apache/spark/blob/master/dev/connect-gen-protos.sh) |
|
Thank you, @HyukjinKwon . For now, apparently, PySpark Let me tackle the issues step-by-step. I'll make a JAVA part very soon with the regenerated code. I'm working in the context of the umbrella JIRA .
I hope to achieve all Python 3.8/3.9/3.10/3.11/3.12 for Apache Spark 4.0.0 for Spark Connect project in the community Daily CI level, @HyukjinKwon , @hvanhovell , @grundprinzip . If we need to abandon Python 3.11 and 3.12 for |
|
Merged to master. |
|
Here is the Java part PR. |
|
Thanks for doing this. |
What changes were proposed in this pull request?
This PR aims to upgrade
protobuffrom3.20.3to4.25.1to fix PySpark failures on Python 3.11 environment for Apache Spark 4.0.0.Why are the changes needed?
Currently, Python 3.11 Daily CI is failing.
v4.25.0is the first release whereprotobufstarts to support Python 3.11 officially.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
I also verified this manually.
Was this patch authored or co-authored using generative AI tooling?
No.