Skip to content

[SPARK-1511] use Files.move instead of renameTo in TestUtils.scala #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
advancedxy wants to merge 2 commits into from
Closed

[SPARK-1511] use Files.move instead of renameTo in TestUtils.scala #427

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f95550
use Files.move instead of renameTo to handle the src and dest files are
advancedxy Apr 16, 2014
a2b97c7
Based on @srowen's comment, assert file existence.
advancedxy Apr 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/src/main/scala/org/apache/spark/TestUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,12 @@ private[spark] object TestUtils {
val result = new File(fileName)
if (!result.exists()) throw new Exception("Compiled file not found: " + fileName)
val out = new File(destDir, fileName)
result.renameTo(out)

// renameTo cannot handle in and out files in different filesystems
// use google's Files.move instead
Files.move(result, out)

if (!out.exists()) throw new Exception("Destination file not moved: " + out)
Copy link
Member

@srowen srowen Apr 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comment: it would be nicer to assert that the file exists, or else throw IOException at least and not Exception. The existing instance of Exception above could also be changed.

Copy link
Contributor Author

@advancedxy advancedxy Apr 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. I am considering using assert with message.
The message will contain the absolute path of file. The absolute path
will give more information. what do you think?

assert(out.exists(),"Destination file not moved: " + out.getAbsolutePath())

out
}
}