Skip to content

[SPARK-1511] use Files.move instead of renameTo in TestUtils.scala #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
advancedxy wants to merge 2 commits into from
Closed

[SPARK-1511] use Files.move instead of renameTo in TestUtils.scala #427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f95550
use Files.move instead of renameTo to handle the src and dest files are
advancedxy Apr 16, 2014
a2b97c7
Based on @srowen's comment, assert file existence.
advancedxy Apr 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions core/src/main/scala/org/apache/spark/TestUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,14 @@ private[spark] object TestUtils {

val fileName = className + ".class"
val result = new File(fileName)
if (!result.exists()) throw new Exception("Compiled file not found: " + fileName)
assert(result.exists(), "Compiled file not found: " + result.getAbsolutePath())
val out = new File(destDir, fileName)
result.renameTo(out)

// renameTo cannot handle in and out files in different filesystems
// use google's Files.move instead
Files.move(result, out)

assert(out.exists(), "Destination file not moved: " + out.getAbsolutePath())
out
}
}