[SPARK-44531][CONNECT][SQL] Move encoder inference to sql/api #42134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR depends on #42133. |
cloud-fan
approved these changes
Jul 25, 2023
amaliujia
approved these changes
Jul 25, 2023
Contributor
Author
|
Merging. The Python failures are a known problem. |
hvanhovell
added a commit
that referenced
this pull request
Jul 26, 2023
### What changes were proposed in this pull request? This PR move encoder inference (ScalaReflection/RowEncoder/JavaTypeInference) into sql/api. ### Why are the changes needed? We want to use encoder inference in the spark connect scala client. The client's dependency to catalyst is going away, so we need to move this. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes #42134 from hvanhovell/SPARK-44531. Authored-by: Herman van Hovell <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit 071feab) Signed-off-by: Herman van Hovell <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR move encoder inference (ScalaReflection/RowEncoder/JavaTypeInference) into sql/api.
Why are the changes needed?
We want to use encoder inference in the spark connect scala client. The client's dependency to catalyst is going away, so we need to move this.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.