[SPARK-44530][CORE][CONNECT] Move SparkBuildInfo to common/util #42133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @amaliujia |
cloud-fan
approved these changes
Jul 25, 2023
amaliujia
approved these changes
Jul 25, 2023
Contributor
|
The CI doesn't look relevant. Pyspark jobs seem to have issues. |
Contributor
|
There may be some issue. Before this PR, after packaging through Maven, there would be a file named However, after this PR, I did not find it in |
Contributor
|
I build a new client with this pr(dev/make-distribution.sh --tgz ), then run |
LuciferYang
reviewed
Jul 25, 2023
common/utils/pom.xml
Outdated
| <!-- Execute the shell script to generate the spark build information. --> | ||
| <target> | ||
| <exec executable="${shell}"> | ||
| <arg value="${project.basedir}/../build/${spark-build-info-script}"/> |
Contributor
There was a problem hiding this comment.
Suggested change
| <arg value="${project.basedir}/../build/${spark-build-info-script}"/> | |
| <arg value="${project.basedir}/../../build/${spark-build-info-script}"/> |
Contributor
There was a problem hiding this comment.
@hvanhovell with this change , bin/spark-shell --master local can run successful
Contributor
Author
|
Merging this. Failures are unrelated. |
hvanhovell
added a commit
that referenced
this pull request
Jul 26, 2023
### What changes were proposed in this pull request? This PR moves `SparkBuildInfo` and the code that generates its properties to `common/util`. ### Why are the changes needed? We need `SparkBuildInfo` in the connect scala client and we are removing connect's dependency on `core`. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests. Closes #42133 from hvanhovell/SPARK-44530. Authored-by: Herman van Hovell <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit 3518799) Signed-off-by: Herman van Hovell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR moves
SparkBuildInfoand the code that generates its properties tocommon/util.Why are the changes needed?
We need
SparkBuildInfoin the connect scala client and we are removing connect's dependency oncore.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.