Skip to content

[SPARK-44153][CORE][UI][FOLLOWUP] Use JAVA_HOME and stderr #41731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-44153][CORE][UI][FOLLOWUP] Use JAVA_HOME and stderr #41731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions core/src/main/scala/org/apache/spark/util/Utils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2291,15 +2291,16 @@ private[spark] object Utils extends Logging with SparkClassUtils {
def getHeapHistogram(): Array[String] = {
// From Java 9+, we can use 'ProcessHandle.current().pid()'
val pid = getProcessName().split("@").head
val builder = new ProcessBuilder("jmap", "-histo:live", pid)
builder.redirectErrorStream(true)
val jmap = System.getProperty("java.home") + "/bin/jmap"
val builder = new ProcessBuilder(jmap, "-histo:live", pid)
val p = builder.start()
val r = new BufferedReader(new InputStreamReader(p.getInputStream()))
val rows = ArrayBuffer.empty[String]
var line = ""
while (line != null) {
if (line.nonEmpty) rows += line
line = r.readLine()
Utils.tryWithResource(new BufferedReader(new InputStreamReader(p.getInputStream()))) { r =>
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mridulm . I'll make another PR to limit the number of results and to address your comment for readLine parts. In this PR, I just wrapped with tryWithResource.

var line = ""
while (line != null) {
if (line.nonEmpty) rows += line
line = r.readLine()
}
}
rows.toArray
}
Expand Down