[SPARK-44153][CORE][UI][FOLLOWUP] Use JAVA_HOME and stderr #41731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
dongjoon-hyun
commented
Jun 26, 2023
| while (line != null) { | ||
| if (line.nonEmpty) rows += line | ||
| line = r.readLine() | ||
| Utils.tryWithResource(new BufferedReader(new InputStreamReader(p.getInputStream()))) { r => |
Member
Author
There was a problem hiding this comment.
@mridulm . I'll make another PR to limit the number of results and to address your comment for readLine parts. In this PR, I just wrapped with tryWithResource.
yaooqinn
approved these changes
Jun 26, 2023
pan3793
approved these changes
Jun 26, 2023
Member
pan3793
left a comment
pan3793
left a comment
There was a problem hiding this comment.
@dongjoon-hyun thanks for fixing this issue.
Member
Author
Member
Author
|
Merged to master! |
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
### What changes were proposed in this pull request? This is a follow-up of apache#41709 to address the review comments. ### Why are the changes needed? 1. Use `JAVA_HOME` prefixed `jmap` to ensure the same version's `JVM` and JMAP. 2. Use the existing stderr instead of merging `stderr` and `stdout` via `redirectErrorStream` 3. Use `tryWithResource`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. Closes apache#41731 from dongjoon-hyun/SPARK-44153-2. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Mrhs121
pushed a commit
to Mrhs121/spark
that referenced
this pull request
Apr 17, 2024
### What changes were proposed in this pull request? This is a follow-up of apache#41709 to address the review comments. ### Why are the changes needed? 1. Use `JAVA_HOME` prefixed `jmap` to ensure the same version's `JVM` and JMAP. 2. Use the existing stderr instead of merging `stderr` and `stdout` via `redirectErrorStream` 3. Use `tryWithResource`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. Closes apache#41731 from dongjoon-hyun/SPARK-44153-2. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 646388e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #41709 to address the review comments.
Why are the changes needed?
JAVA_HOMEprefixedjmapto ensure the same version'sJVMand JMAP.stderrandstdoutviaredirectErrorStreamtryWithResource.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.