[SPARK-42656][CONNECT][Followup] Spark Connect Shell #40305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
changed the title
Contributor
Author
|
If this PR accepted then no need to merge #40303 as this PR override the changes needed there. |
hvanhovell
pushed a commit
that referenced
this pull request
Mar 7, 2023
### What changes were proposed in this pull request? Add spark connect shell to start the spark shell with spark connect enabled. Added "-Pconnect" to build the spark connect in the distributions. Simplified the dev shell scripts with "-Pconnect" command. ### Why are the changes needed? Allow users to play with spark connect easily. ### Does this PR introduce _any_ user-facing change? Yes. Added a new shell script and "-Pconnect" build option. ### How was this patch tested? Manually tested. Closes #40305 from zhenlineo/connect-shell. Authored-by: Zhen Li <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit 2e7207f) Signed-off-by: Herman van Hovell <[email protected]>
Contributor
|
Merging. |
LuciferYang
reviewed
Mar 7, 2023
| sparkContext = sparkSession.sparkContext | ||
| sparkSession | ||
| } catch { | ||
| case e: ClassNotFoundException if isShellSession && e.getMessage.contains( |
hvanhovell
pushed a commit
that referenced
this pull request
Mar 7, 2023
…Exception` catch to `repl.Main` for Scala 2.13 ### What changes were proposed in this pull request? This pr add the same `ClassNotFoundException` catch to `repl.Main` for Scala 2.13 as #40305 due `org/apache/spark/repl/Main.scala` is Scala version sensitive。 ### Why are the changes needed? Make sure Scala 2.12 and 2.13 have the same logic ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual check Closes #40318 from LuciferYang/SPARK-42656-FOLLOWUP. Authored-by: yangjie01 <[email protected]> Signed-off-by: Herman van Hovell <[email protected]>
hvanhovell
pushed a commit
that referenced
this pull request
Mar 7, 2023
…Exception` catch to `repl.Main` for Scala 2.13 ### What changes were proposed in this pull request? This pr add the same `ClassNotFoundException` catch to `repl.Main` for Scala 2.13 as #40305 due `org/apache/spark/repl/Main.scala` is Scala version sensitive。 ### Why are the changes needed? Make sure Scala 2.12 and 2.13 have the same logic ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual check Closes #40318 from LuciferYang/SPARK-42656-FOLLOWUP. Authored-by: yangjie01 <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit 67328de) Signed-off-by: Herman van Hovell <[email protected]>
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Hi, @zhenlineo and @hvanhovell . We need to register new profile as build_profile_flags.
Here is the PR.
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Add spark connect shell to start the spark shell with spark connect enabled. Added "-Pconnect" to build the spark connect in the distributions. Simplified the dev shell scripts with "-Pconnect" command. ### Why are the changes needed? Allow users to play with spark connect easily. ### Does this PR introduce _any_ user-facing change? Yes. Added a new shell script and "-Pconnect" build option. ### How was this patch tested? Manually tested. Closes apache#40305 from zhenlineo/connect-shell. Authored-by: Zhen Li <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit 2e7207f) Signed-off-by: Herman van Hovell <[email protected]>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…Exception` catch to `repl.Main` for Scala 2.13 ### What changes were proposed in this pull request? This pr add the same `ClassNotFoundException` catch to `repl.Main` for Scala 2.13 as apache#40305 due `org/apache/spark/repl/Main.scala` is Scala version sensitive。 ### Why are the changes needed? Make sure Scala 2.12 and 2.13 have the same logic ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual check Closes apache#40318 from LuciferYang/SPARK-42656-FOLLOWUP. Authored-by: yangjie01 <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit 67328de) Signed-off-by: Herman van Hovell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add spark connect shell to start the spark shell with spark connect enabled.
Added "-Pconnect" to build the spark connect in the distributions.
Simplified the dev shell scripts with "-Pconnect" command.
Why are the changes needed?
Allow users to play with spark connect easily.
Does this PR introduce any user-facing change?
Yes. Added a new shell script and "-Pconnect" build option.
How was this patch tested?
Manually tested.