[SPARK-42793][CONNECT] connect module requires build_profile_flags
#40424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
HyukjinKwon
approved these changes
Mar 14, 2023
Member
|
Merged to master and branch-3.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 14, 2023
### What changes were proposed in this pull request? This PR aims to add `build_profile_flags` to `connect` module. ### Why are the changes needed? SPARK-42656 added `connect` profile. https://github.com/apache/spark/blob/4db8e7b7944302a3929dd6a1197ea1385eecc46a/assembly/pom.xml#L155-L164 ### Does this PR introduce _any_ user-facing change? No. This is a dev-only change. ### How was this patch tested? Pass the CIs. Closes #40424 from dongjoon-hyun/SPARK-42793. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit f55db28) Signed-off-by: Hyukjin Kwon <[email protected]>
Member
Author
|
Thank you, @HyukjinKwon ! |
Member
Author
|
BTW, |
Member
|
👌 |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? This PR aims to add `build_profile_flags` to `connect` module. ### Why are the changes needed? SPARK-42656 added `connect` profile. https://github.com/apache/spark/blob/4db8e7b7944302a3929dd6a1197ea1385eecc46a/assembly/pom.xml#L155-L164 ### Does this PR introduce _any_ user-facing change? No. This is a dev-only change. ### How was this patch tested? Pass the CIs. Closes apache#40424 from dongjoon-hyun/SPARK-42793. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit f55db28) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
build_profile_flagstoconnectmodule.Why are the changes needed?
SPARK-42656 added
connectprofile.spark/assembly/pom.xml
Lines 155 to 164 in 4db8e7b
Does this PR introduce any user-facing change?
No. This is a dev-only change.
How was this patch tested?
Pass the CIs.