Skip to content

[SPARK-42665][CONNECT][Test] Mute Scala Client UDF test #40304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhenlineo wants to merge 2 commits into from
Closed

[SPARK-42665][CONNECT][Test] Mute Scala Client UDF test #40304

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fe5c4a
Mute udf test
zhenlineo Mar 6, 2023
7c7ee91
fix
zhenlineo Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ class ClientE2ETestSuite extends RemoteSparkSession {
assert(result(2) == 2)
}

test("simple udf") {
// TODO (SPARK-42665): Ignore this test until the udf is fully implemented.
ignore("simple udf") {
Copy link
Contributor

@amaliujia amaliujia Mar 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think the common way to do so is this format:

ignore("SPARK-31855: generate test files for checking compatibility with Spark 2.4/3.2").

Basically you leave the SPARK-XXXX and the reason in the test name.

def dummyUdf(x: Int): Int = x + 5
val myUdf = udf(dummyUdf _)
val df = spark.range(5).select(myUdf(Column("id")))
Expand Down