[SPARK-42665][CONNECT][Test] Mute Scala Client UDF test #40304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
changed the title
amaliujia
reviewed
Mar 6, 2023
|
|
||
| test("simple udf") { | ||
| // TODO (SPARK-42665): Ignore this test until the udf is fully implemented. | ||
| ignore("simple udf") { |
Contributor
There was a problem hiding this comment.
nit: I think the common way to do so is this format:
ignore("SPARK-31855: generate test files for checking compatibility with Spark 2.4/3.2").
Basically you leave the SPARK-XXXX and the reason in the test name.
Contributor
|
cc @HyukjinKwon , can we merge this first before new RC? otherwise, the maven test will still fail |
HyukjinKwon
approved these changes
Mar 7, 2023
Member
|
Merged to master and branch-3.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 7, 2023
### What changes were proposed in this pull request? Mute the UDF test. ### Why are the changes needed? The test fails during maven test runs because the server cannot find the udf in the classpath. The test will be fixed once the udf artifact sync is finished. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A Closes #40304 from zhenlineo/mute-udf-test. Authored-by: Zhen Li <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit cf3c34b) Signed-off-by: Hyukjin Kwon <[email protected]>
Contributor
|
Thanks @HyukjinKwon :) |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Mute the UDF test. ### Why are the changes needed? The test fails during maven test runs because the server cannot find the udf in the classpath. The test will be fixed once the udf artifact sync is finished. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A Closes apache#40304 from zhenlineo/mute-udf-test. Authored-by: Zhen Li <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit cf3c34b) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Mute the UDF test.
Why are the changes needed?
The test fails during maven test runs because the server cannot find the udf in the classpath. The test will be fixed once the udf artifact sync is finished.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A