Skip to content

Comments

[SPARK-41857][CONNECT][TESTS] Enable test_between_function, test_datetime_functions, test_expr, test_math_functions, test_window_functions_cumulative_sum, test_corr, test_cov, test_crosstab, test_approxQuantile#39359

Closed
techaddict wants to merge 2 commits intoapache:masterfrom
techaddict:SPARK-41857

Conversation

@techaddict
Copy link
Contributor

What changes were proposed in this pull request?

This PR enables the reused PySpark tests in Spark Connect that pass now.

Why are the changes needed?

To make sure on the test coverage.

Does this PR introduce any user-facing change?

No, test-only.

How was this patch tested?

Enabling tests

…time_functions, test_expr, test_function_parity, test_math_functions, test_window_functions_cumulative_sum, test_corr, test_cov, test_crosstab, test_approxQuantile
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@techaddict techaddict changed the title [SPARK-41857][CONNECT][TESTS] Enable test_between_function, test_datetime_functions, test_expr, test_function_parity, test_math_functions, test_window_functions_cumulative_sum, test_corr, test_cov, test_crosstab, test_approxQuantile [SPARK-41857][CONNECT][TESTS] Enable test_between_function, test_datetime_functions, test_expr, test_math_functions, test_window_functions_cumulative_sum, test_corr, test_cov, test_crosstab, test_approxQuantile Jan 3, 2023
@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants