-
Notifications
You must be signed in to change notification settings - Fork 29.3k
[SPARK-41429][UI] Protobuf serializer for RDDOperationGraphWrapper #39110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
f311654
fb0f2ef
19b955b
ea60f3c
038d57d
877faaf
e0dec7f
f0c35d6
5912ced
7fe0932
00c7135
641fc83
7684fbf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.status.protobuf | ||
|
|
||
| import scala.collection.JavaConverters._ | ||
|
|
||
| import org.apache.spark.rdd.DeterministicLevel | ||
| import org.apache.spark.status.{RDDOperationClusterWrapper, RDDOperationGraphWrapper} | ||
| import org.apache.spark.ui.scope.{RDDOperationEdge, RDDOperationNode} | ||
|
|
||
| class RDDOperationGraphWrapperSerializer extends ProtobufSerDe { | ||
|
|
||
| override val supportClass: Class[_] = classOf[RDDOperationGraphWrapper] | ||
|
|
||
| override def serialize(input: Any): Array[Byte] = { | ||
| serialize(input.asInstanceOf[RDDOperationGraphWrapper]) | ||
|
techaddict marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| private def serialize(input: RDDOperationGraphWrapper): Array[Byte] = { | ||
| val builder = StoreTypes.RDDOperationGraphWrapper.newBuilder() | ||
| builder.setStageId(input.stageId.toLong) | ||
| input.edges.foreach { e => | ||
| builder.addEdges(serializeRDDOperationEdge(e)) | ||
| } | ||
| input.outgoingEdges.foreach { e => | ||
| builder.addOutgoingEdges(serializeRDDOperationEdge(e)) | ||
| } | ||
| input.incomingEdges.foreach { e => | ||
| builder.addIncomingEdges(serializeRDDOperationEdge(e)) | ||
| } | ||
| builder.setRootCluster(serializeRDDOperationClusterWrapper(input.rootCluster)) | ||
| builder.build().toByteArray | ||
| } | ||
|
|
||
| def deserialize(bytes: Array[Byte]): RDDOperationGraphWrapper = { | ||
| val wrapper = StoreTypes.RDDOperationGraphWrapper.parseFrom(bytes) | ||
| new RDDOperationGraphWrapper( | ||
| stageId = wrapper.getStageId.toInt, | ||
| edges = wrapper.getEdgesList.asScala.map(deserializeRDDOperationEdge).toSeq, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I found that there are many redundant This conversion will not affect Scala 2.12, but will make the performance of Scala 2.13 worse than Scala 2.12. Since these are internal definitions of Spark, I suggest explicitly defining them as
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @LuciferYang Agree, and since these are private[spark], it shouldn't be an issue.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
@LuciferYang could you explain details?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. https://github.com/apache/spark/pull/39215/files is doing some refactor work, which does not block this one |
||
| outgoingEdges = wrapper.getOutgoingEdgesList.asScala.map(deserializeRDDOperationEdge).toSeq, | ||
| incomingEdges = wrapper.getIncomingEdgesList.asScala.map(deserializeRDDOperationEdge).toSeq, | ||
| rootCluster = deserializeRDDOperationClusterWrapper(wrapper.getRootCluster) | ||
| ) | ||
| } | ||
|
|
||
| private def serializeRDDOperationClusterWrapper(op: RDDOperationClusterWrapper): | ||
| StoreTypes.RDDOperationClusterWrapper = { | ||
| val builder = StoreTypes.RDDOperationClusterWrapper.newBuilder() | ||
| builder.setId(op.id) | ||
| builder.setName(op.name) | ||
| op.childNodes.foreach { node => | ||
| builder.addChildNodes(serializeRDDOperationNode(node)) | ||
| } | ||
| op.childClusters.foreach { cluster => | ||
| builder.addChildClusters(serializeRDDOperationClusterWrapper(cluster)) | ||
| } | ||
| builder.build() | ||
| } | ||
|
|
||
| private def deserializeRDDOperationClusterWrapper(op: StoreTypes.RDDOperationClusterWrapper): | ||
| RDDOperationClusterWrapper = { | ||
| new RDDOperationClusterWrapper( | ||
| id = op.getId, | ||
| name = op.getName, | ||
| childNodes = op.getChildNodesList.asScala.map(deserializeRDDOperationNode).toSeq, | ||
| childClusters = | ||
| op.getChildClustersList.asScala.map(deserializeRDDOperationClusterWrapper).toSeq | ||
| ) | ||
| } | ||
|
|
||
| private def serializeRDDOperationNode(node: RDDOperationNode): StoreTypes.RDDOperationNode = { | ||
| val builder = StoreTypes.RDDOperationNode.newBuilder() | ||
| builder.setId(node.id) | ||
| builder.setName(node.name) | ||
| builder.setCached(node.cached) | ||
| builder.setBarrier(node.barrier) | ||
| builder.setCallsite(node.callsite) | ||
| builder.setOutputDeterministicLevel(serializeDeterministicLevel(node.outputDeterministicLevel)) | ||
| builder.build() | ||
| } | ||
|
|
||
| private def deserializeRDDOperationNode(node: StoreTypes.RDDOperationNode): RDDOperationNode = { | ||
| RDDOperationNode( | ||
| id = node.getId, | ||
| name = node.getName, | ||
| cached = node.getCached, | ||
| barrier = node.getBarrier, | ||
| callsite = node.getCallsite, | ||
| outputDeterministicLevel = DeterministicLevel(node.getOutputDeterministicLevel.getNumber) | ||
| ) | ||
| } | ||
|
|
||
| private def serializeRDDOperationEdge(edge: RDDOperationEdge): StoreTypes.RDDOperationEdge = { | ||
| val builder = StoreTypes.RDDOperationEdge.newBuilder() | ||
| builder.setFromId(edge.fromId) | ||
| builder.setToId(edge.toId) | ||
| builder.build() | ||
| } | ||
|
|
||
| private def deserializeRDDOperationEdge(edge: StoreTypes.RDDOperationEdge): RDDOperationEdge = { | ||
| RDDOperationEdge( | ||
| fromId = edge.getFromId, | ||
| toId = edge.getToId) | ||
| } | ||
|
|
||
| private def serializeDeterministicLevel(d: DeterministicLevel.Value): | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only used by one place, maybe inline is ok
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DeterministicLevel is used in multiple places; we might need to re-use it. |
||
| StoreTypes.DeterministicLevel = { | ||
| StoreTypes.DeterministicLevel.valueOf(d.toString) | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.