-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-41429][UI] Protobuf serializer for RDDOperationGraphWrapper #39110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
techaddict
wants to merge
13
commits into
apache:master
from
techaddict:SPARK-41429-RDDOperationGraphWrapper
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f311654
[SPARK-41429] Protobuf serializer for RDDOperationGraphWrapper
techaddict fb0f2ef
fix imports
techaddict 19b955b
Merge branch 'master' into SPARK-41429-RDDOperationGraphWrapper
techaddict ea60f3c
fix whitespace
techaddict 038d57d
Merge branch 'master' into SPARK-41429-RDDOperationGraphWrapper
techaddict 877faaf
update implementation
techaddict e0dec7f
Merge branch 'master' into SPARK-41429-RDDOperationGraphWrapper
techaddict f0c35d6
Merge branch 'master' into SPARK-41429-RDDOperationGraphWrapper
techaddict 5912ced
fix stageId
techaddict 7fe0932
Merge branch 'master' into SPARK-41429-RDDOperationGraphWrapper
techaddict 00c7135
address comments
techaddict 641fc83
Merge branch 'master' into SPARK-41429-RDDOperationGraphWrapper
techaddict 7684fbf
Update RDDOperationGraphWrapperSerializer.scala
techaddict File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120 changes: 120 additions & 0 deletions
120
.../src/main/scala/org/apache/spark/status/protobuf/RDDOperationGraphWrapperSerializer.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.status.protobuf | ||
|
|
||
| import scala.collection.JavaConverters._ | ||
|
|
||
| import org.apache.spark.rdd.DeterministicLevel | ||
| import org.apache.spark.status.{RDDOperationClusterWrapper, RDDOperationGraphWrapper} | ||
| import org.apache.spark.ui.scope.{RDDOperationEdge, RDDOperationNode} | ||
|
|
||
| class RDDOperationGraphWrapperSerializer extends ProtobufSerDe { | ||
|
|
||
| override val supportClass: Class[_] = classOf[RDDOperationGraphWrapper] | ||
|
|
||
| override def serialize(input: Any): Array[Byte] = { | ||
| val op = input.asInstanceOf[RDDOperationGraphWrapper] | ||
| val builder = StoreTypes.RDDOperationGraphWrapper.newBuilder() | ||
| builder.setStageId(op.stageId.toLong) | ||
| op.edges.foreach { e => | ||
| builder.addEdges(serializeRDDOperationEdge(e)) | ||
| } | ||
| op.outgoingEdges.foreach { e => | ||
| builder.addOutgoingEdges(serializeRDDOperationEdge(e)) | ||
| } | ||
| op.incomingEdges.foreach { e => | ||
| builder.addIncomingEdges(serializeRDDOperationEdge(e)) | ||
| } | ||
| builder.setRootCluster(serializeRDDOperationClusterWrapper(op.rootCluster)) | ||
| builder.build().toByteArray | ||
| } | ||
|
|
||
| def deserialize(bytes: Array[Byte]): RDDOperationGraphWrapper = { | ||
| val wrapper = StoreTypes.RDDOperationGraphWrapper.parseFrom(bytes) | ||
| new RDDOperationGraphWrapper( | ||
| stageId = wrapper.getStageId.toInt, | ||
| edges = wrapper.getEdgesList.asScala.map(deserializeRDDOperationEdge).toSeq, | ||
| outgoingEdges = wrapper.getOutgoingEdgesList.asScala.map(deserializeRDDOperationEdge).toSeq, | ||
| incomingEdges = wrapper.getIncomingEdgesList.asScala.map(deserializeRDDOperationEdge).toSeq, | ||
| rootCluster = deserializeRDDOperationClusterWrapper(wrapper.getRootCluster) | ||
| ) | ||
| } | ||
|
|
||
| private def serializeRDDOperationClusterWrapper(op: RDDOperationClusterWrapper): | ||
| StoreTypes.RDDOperationClusterWrapper = { | ||
| val builder = StoreTypes.RDDOperationClusterWrapper.newBuilder() | ||
| builder.setId(op.id) | ||
| builder.setName(op.name) | ||
| op.childNodes.foreach { node => | ||
| builder.addChildNodes(serializeRDDOperationNode(node)) | ||
| } | ||
| op.childClusters.foreach { cluster => | ||
| builder.addChildClusters(serializeRDDOperationClusterWrapper(cluster)) | ||
| } | ||
| builder.build() | ||
| } | ||
|
|
||
| private def deserializeRDDOperationClusterWrapper(op: StoreTypes.RDDOperationClusterWrapper): | ||
| RDDOperationClusterWrapper = { | ||
| new RDDOperationClusterWrapper( | ||
| id = op.getId, | ||
| name = op.getName, | ||
| childNodes = op.getChildNodesList.asScala.map(deserializeRDDOperationNode).toSeq, | ||
| childClusters = | ||
| op.getChildClustersList.asScala.map(deserializeRDDOperationClusterWrapper).toSeq | ||
| ) | ||
| } | ||
|
|
||
| private def serializeRDDOperationNode(node: RDDOperationNode): StoreTypes.RDDOperationNode = { | ||
| val outputDeterministicLevel = StoreTypes.RDDOperationNode.DeterministicLevel | ||
| .valueOf(node.outputDeterministicLevel.toString) | ||
| val builder = StoreTypes.RDDOperationNode.newBuilder() | ||
| builder.setId(node.id) | ||
| builder.setName(node.name) | ||
| builder.setCached(node.cached) | ||
| builder.setBarrier(node.barrier) | ||
| builder.setCallsite(node.callsite) | ||
| builder.setOutputDeterministicLevel(outputDeterministicLevel) | ||
| builder.build() | ||
| } | ||
|
|
||
| private def deserializeRDDOperationNode(node: StoreTypes.RDDOperationNode): RDDOperationNode = { | ||
| RDDOperationNode( | ||
| id = node.getId, | ||
| name = node.getName, | ||
| cached = node.getCached, | ||
| barrier = node.getBarrier, | ||
| callsite = node.getCallsite, | ||
| outputDeterministicLevel = | ||
| DeterministicLevel.withName(node.getOutputDeterministicLevel.toString) | ||
| ) | ||
| } | ||
|
|
||
| private def serializeRDDOperationEdge(edge: RDDOperationEdge): StoreTypes.RDDOperationEdge = { | ||
| val builder = StoreTypes.RDDOperationEdge.newBuilder() | ||
| builder.setFromId(edge.fromId) | ||
| builder.setToId(edge.toId) | ||
| builder.build() | ||
| } | ||
|
|
||
| private def deserializeRDDOperationEdge(edge: StoreTypes.RDDOperationEdge): RDDOperationEdge = { | ||
| RDDOperationEdge( | ||
| fromId = edge.getFromId, | ||
| toId = edge.getToId) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that there are many redundant
toSeqfor Scala 2.12 instatus.protobufpackage, this is for Scala 2.13 compatibility due toSeqrepresentscollection.Seqin Scala 2.12 andimmutable.Seqin Scala 2.13.This conversion will not affect Scala 2.12, but will make the performance of Scala 2.13 worse than Scala 2.12. Since these are internal definitions of Spark, I suggest explicitly defining them as
scala.collection.Seqto make no performance difference between Scala 2.12 and Scala 2.13. Do you think it's ok? @gengliangwangThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuciferYang Agree, and since these are private[spark], it shouldn't be an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuciferYang could you explain details?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/apache/spark/pull/39215/files is doing some refactor work, which does not block this one