Skip to content

[SPARK-41378][SQL][FOLLOWUP] Use toAttributeMap before comparison #39038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-41378][SQL][FOLLOWUP] Use toAttributeMap before comparison #39038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ import org.apache.spark.sql._
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.analysis.{CannotReplaceMissingTableException, NoSuchDatabaseException, NoSuchNamespaceException, TableAlreadyExistsException}
import org.apache.spark.sql.catalyst.parser.ParseException
import org.apache.spark.sql.catalyst.plans.logical.ColumnStat
import org.apache.spark.sql.catalyst.statsEstimation.StatsEstimationTestBase
import org.apache.spark.sql.catalyst.util.{DateTimeUtils, ResolveDefaultColumns}
import org.apache.spark.sql.connector.catalog._
import org.apache.spark.sql.connector.catalog.CatalogManager.SESSION_CATALOG_NAME
Expand All @@ -47,7 +49,7 @@ import org.apache.spark.unsafe.types.UTF8String

abstract class DataSourceV2SQLSuite
extends InsertIntoTests(supportsDynamicOverwrite = true, includeSQLOnlyTests = true)
with DeleteFromTests with DatasourceV2SQLBase {
with DeleteFromTests with DatasourceV2SQLBase with StatsEstimationTestBase {

protected val v2Source = classOf[FakeV2Provider].getName
override protected val v2Format = v2Source
Expand Down Expand Up @@ -2779,17 +2781,16 @@ class DataSourceV2SQLSuiteV1Filter
" (4, null), (5, 'test5')")
val df = spark.sql("select * from testcat.test")

val expectedColumnStats = Seq(
"id" -> ColumnStat(Some(5), None, None, Some(0), None, None, None, 2),
"data" -> ColumnStat(Some(3), None, None, Some(3), None, None, None, 2))
df.queryExecution.optimizedPlan.collect {
case scan: DataSourceV2ScanRelation =>
val stats = scan.stats
assert(stats.sizeInBytes == 200)
assert(stats.rowCount.get == 5)
val colStats = stats.attributeStats.values.toArray
assert(colStats.length == 2)
assert(colStats(0).distinctCount.get == 3)
assert(colStats(0).nullCount.get == 3)
assert(colStats(1).distinctCount.get == 5)
assert(colStats(1).nullCount.get == 0)
assert(stats.attributeStats ==
toAttributeMap(expectedColumnStats, df.queryExecution.optimizedPlan))
}
}

Expand Down