[SPARK-41378][SQL][FOLLOWUP] Use toAttributeMap before comparison #39038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @huaxingao and @HyukjinKwon |
huaxingao
approved these changes
Dec 12, 2022
Member
Author
|
Thank you, @huaxingao . |
Member
|
Thx! |
Contributor
|
thanks for the quick fix! |
Contributor
|
Thanks @dongjoon-hyun |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? This PR is a follow-up to fix Scala 2.13 test failure by using `toAttributeMap` before comparion. ### Why are the changes needed? To recover Scala 2.13 tests. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs and manually run Scala 2.13. ``` $ dev/change-scala-version.sh 2.13 $ build/sbt -Pscala-2.13 "sql/testOnly *.DataSourceV2SQLSuiteV1Filter -- -z SPARK-41378" ... [info] DataSourceV2SQLSuiteV1Filter: [info] - SPARK-41378: test column stats (3 seconds, 312 milliseconds) [info] Run completed in 11 seconds, 159 milliseconds. [info] Total number of tests run: 1 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. ``` Closes apache#39038 from dongjoon-hyun/SPARK-41378. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a follow-up to fix Scala 2.13 test failure by using
toAttributeMapbefore comparion.Why are the changes needed?
To recover Scala 2.13 tests.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs and manually run Scala 2.13.