Skip to content

[MINOR] Fix Python Lint#38932

Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng:fix_lint
Closed

[MINOR] Fix Python Lint#38932
zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng:fix_lint

Conversation

@zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

Fix Python Lint

Why are the changes needed?

Python Linter is now broken

starting black test...
black checks failed:
would reformat python/pyspark/testing/connectutils.py

Oh no! 💥 💔 💥
1 file would be reformatted, 391 files would be left unchanged.
Please run 'dev/reformat-python' script.
1

How was this patch tested?

manually test

@zhengruifeng
Copy link
Contributor Author

@zhengruifeng
Copy link
Contributor Author

wait for a moment

@zhengruifeng
Copy link
Contributor Author

there is another error:

python/pyspark/sql/tests/connect/test_connect_function.py:29: error: Incompatible import of "PandasOnSparkTestCase" (imported name has type "Type[ReusedSQLTestCase]", local name has type "Type[PandasOnSparkTestCase]")  [misc]

@dongjoon-hyun
Copy link
Member

For the first one, I fixed here.

For the second one, let me check.

@zhengruifeng
Copy link
Contributor Author

thanks, let me close this one

@zhengruifeng zhengruifeng deleted the fix_lint branch December 6, 2022 07:26
@dongjoon-hyun
Copy link
Member

For the second one, does it come from GitHub Action log?

@zhengruifeng
Copy link
Contributor Author

For the second one, does it come from GitHub Action log?

no, it came from local dev/lint-python

@dongjoon-hyun
Copy link
Member

Thank you. Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments