[SPARK-41001][CONNECT][TESTS][FOLLOWUP] ChannelBuilderTests should be skipped by should_test_connect flag#38931
Closed
dongjoon-hyun wants to merge 3 commits intoapache:masterfrom
dongjoon-hyun:SPARK-41001
Closed
[SPARK-41001][CONNECT][TESTS][FOLLOWUP] ChannelBuilderTests should be skipped by should_test_connect flag#38931dongjoon-hyun wants to merge 3 commits intoapache:masterfrom dongjoon-hyun:SPARK-41001
ChannelBuilderTests should be skipped by should_test_connect flag#38931dongjoon-hyun wants to merge 3 commits intoapache:masterfrom
dongjoon-hyun:SPARK-41001
Conversation
… skipped by should_test_connect flag
dongjoon-hyun
commented
Dec 6, 2022
| return DataFrame.withPlan(SQL(query), cls.connect) # type: ignore | ||
|
|
||
| if have_pandas: | ||
|
|
Member
Author
There was a problem hiding this comment.
Sorry, but I piggy-back this python-style fix. This style issue is introduced in the previous commit separately today.
$ dev/reformat-python
reformatted python/pyspark/testing/connectutils.py
All done! ✨ 🍰 ✨
1 file reformatted, 391 files left unchanged.
grundprinzip
approved these changes
Dec 6, 2022
Member
Author
|
Thank you, @grundprinzip . For this PR, I will wait until all the CI passes, @zhengruifeng and @HyukjinKwon |
zhengruifeng
approved these changes
Dec 6, 2022
Member
Author
|
At the last commit, all python linters passed. Thank you again, @zhengruifeng . |
HyukjinKwon
approved these changes
Dec 6, 2022
Member
|
Merged to master. |
Member
Author
|
Thank you, @HyukjinKwon ! |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…e skipped by `should_test_connect` flag ### What changes were proposed in this pull request? This PR aims to skip `ChannelBuilderTests` when `should_test_connect` is false. ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Closes apache#38931 from dongjoon-hyun/SPARK-41001. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to skip
ChannelBuilderTestswhenshould_test_connectis false.Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?