Skip to content

[SPARK-41238][CONNECT][PYTHON][FOLLOWUP] Support DayTimeIntervalType in the client #38818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengruifeng wants to merge 1 commit into from
Closed

[SPARK-41238][CONNECT][PYTHON][FOLLOWUP] Support DayTimeIntervalType in the client #38818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion python/pyspark/sql/connect/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,17 @@ def _proto_schema_to_pyspark_schema(self, schema: pb2.DataType) -> DataType:
elif schema.HasField("timestamp"):
return TimestampType()
elif schema.HasField("day_time_interval"):
return DayTimeIntervalType()
start: Optional[int] = (
schema.day_time_interval.start_field
if schema.day_time_interval.HasField("start_field")
else None
)
end: Optional[int] = (
schema.day_time_interval.end_field
if schema.day_time_interval.HasField("end_field")
else None
)
return DayTimeIntervalType(startField=start, endField=end)
elif schema.HasField("array"):
return ArrayType(
self._proto_schema_to_pyspark_schema(schema.array.element_type),
Expand Down
7 changes: 7 additions & 0 deletions python/pyspark/sql/tests/connect/test_connect_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,13 @@ def test_schema(self):
self.connect.sql(query).schema,
)

# test DayTimeIntervalType
query = """ SELECT INTERVAL '100 10:30' DAY TO MINUTE AS interval """
self.assertEqual(
self.spark.sql(query).schema,
self.connect.sql(query).schema,
)

# test MapType
query = """
SELECT * FROM VALUES
Expand Down