[SPARK-41238][CONNECT][PYTHON][FOLLOWUP] Support DayTimeIntervalType in the client
#38818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
changed the title
DayTimeIntervalType in the clientDayTimeIntervalType in the client
grundprinzip
approved these changes
Nov 28, 2022
Contributor
Author
|
thanks for reivews, merged into master |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…` in the client ### What changes were proposed in this pull request? Support `DayTimeIntervalType` in the client ### Why are the changes needed? In apache#38770, I forgot to deal with `DayTimeIntervalType` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? added test case, the schema should be ``` In [1]: query = """ SELECT INTERVAL '100 10:30' DAY TO MINUTE AS interval """ In [2]: spark.sql(query).schema Out[2]: StructType([StructField('interval', DayTimeIntervalType(0, 2), False)]) ``` Closes apache#38818 from zhengruifeng/connect_type_time_stamp. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…` in the client ### What changes were proposed in this pull request? Support `DayTimeIntervalType` in the client ### Why are the changes needed? In apache#38770, I forgot to deal with `DayTimeIntervalType` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? added test case, the schema should be ``` In [1]: query = """ SELECT INTERVAL '100 10:30' DAY TO MINUTE AS interval """ In [2]: spark.sql(query).schema Out[2]: StructType([StructField('interval', DayTimeIntervalType(0, 2), False)]) ``` Closes apache#38818 from zhengruifeng/connect_type_time_stamp. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support
DayTimeIntervalTypein the clientWhy are the changes needed?
In #38770, I forgot to deal with
DayTimeIntervalTypeDoes this PR introduce any user-facing change?
No
How was this patch tested?
added test case, the schema should be