Skip to content

[SPARK-41183][SQL][FOLLOWUP] Change the name from injectPlanNormalizationRules to injectPlanNormalizationRule #38767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloud-fan wants to merge 1 commit into from
Closed

[SPARK-41183][SQL][FOLLOWUP] Change the name from injectPlanNormalizationRules to injectPlanNormalizationRule #38767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ class SparkSessionExtensions {
* cache hit rate by normalizing different plans to the same form. These rules should never modify
* the result of the LogicalPlan.
*/
def injectPlanNormalizationRules(builder: RuleBuilder): Unit = {
def injectPlanNormalizationRule(builder: RuleBuilder): Unit = {
Copy link
Member

@MaxGekk MaxGekk Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the comment above. It mentions rules too.

Copy link
Contributor Author

@cloud-fan cloud-fan Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I checked other APIs and they use rules in the doc as well. It probably means all the rule that were added by this API.

planNormalizationRules += builder
}

Expand Down
2 changes: 1 addition & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ class SparkSessionExtensionSuite extends SparkFunSuite with SQLHelper {

test("inject plan normalization rules") {
val extensions = create { extensions =>
extensions.injectPlanNormalizationRules { session =>
extensions.injectPlanNormalizationRule { session =>
org.apache.spark.sql.catalyst.optimizer.PushDownPredicates
}
}
Expand Down