[SPARK-41183][SQL][FOLLOWUP] Change the name from injectPlanNormalizationRules to injectPlanNormalizationRule #38767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @viirya |
viirya
approved these changes
Nov 23, 2022
itholic
approved these changes
Nov 23, 2022
MaxGekk
reviewed
Nov 23, 2022
| * the result of the LogicalPlan. | ||
| */ | ||
| def injectPlanNormalizationRules(builder: RuleBuilder): Unit = { | ||
| def injectPlanNormalizationRule(builder: RuleBuilder): Unit = { |
Member
There was a problem hiding this comment.
How about the comment above. It mentions rules too.
Contributor
Author
There was a problem hiding this comment.
good catch! I checked other APIs and they use rules in the doc as well. It probably means all the rule that were added by this API.
HyukjinKwon
approved these changes
Nov 24, 2022
HyukjinKwon
changed the title
Member
|
Merged to master. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…tionRules to injectPlanNormalizationRule ### What changes were proposed in this pull request? Followup of apache#38692. To follow other APIs in `SparkSessionExtensions`, the name should be `inject...Rule` and `build...Rules`. ### Why are the changes needed? typo fix ### Does this PR introduce _any_ user-facing change? not a released API ### How was this patch tested? n/a Closes apache#38767 from cloud-fan/small. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…tionRules to injectPlanNormalizationRule ### What changes were proposed in this pull request? Followup of apache#38692. To follow other APIs in `SparkSessionExtensions`, the name should be `inject...Rule` and `build...Rules`. ### Why are the changes needed? typo fix ### Does this PR introduce _any_ user-facing change? not a released API ### How was this patch tested? n/a Closes apache#38767 from cloud-fan/small. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Followup of #38692. To follow other APIs in
SparkSessionExtensions, the name should beinject...Ruleandbuild...Rules.Why are the changes needed?
typo fix
Does this PR introduce any user-facing change?
not a released API
How was this patch tested?
n/a