[SPARK-41173][SQL] Move require() out from the constructors of string expressions
#38705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
require() out from the constructors of string expressionsrequire() out from the constructors of string expressions
LuciferYang
changed the title
require() out from the constructors of string expressionsrequire() out from the constructors of string expressions
MaxGekk
reviewed
Nov 18, 2022
| -- !query output | ||
| org.apache.spark.sql.AnalysisException | ||
| requirement failed: format_string() should take at least 1 argument; line 1 pos 7 | ||
| 0; line 1 pos 7 |
Member
There was a problem hiding this comment.
hmm, why is that? We should see similar error as for select concat_ws().
LuciferYang
commented
Nov 18, 2022
|
|
||
| require(children.nonEmpty, s"$prettyName() should take at least 1 argument") | ||
| if (!SQLConf.get.getConf(SQLConf.ALLOW_ZERO_INDEX_IN_FORMAT_STRING)) { | ||
| if (children.nonEmpty && !SQLConf.get.getConf(SQLConf.ALLOW_ZERO_INDEX_IN_FORMAT_STRING)) { |
Contributor
Author
There was a problem hiding this comment.
My mistake, need to add nonEmpty condition
MaxGekk
approved these changes
Nov 18, 2022
Member
|
+1, LGTM. Merging to master. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…ng expressions ### What changes were proposed in this pull request? This pr aims to move `require()` out from the constructors of string expressions, include `ConcatWs` and `FormatString`. The args number checking logic moved into `checkInputDataTypes()`. ### Why are the changes needed? Migration onto error classes unifies Spark SQL error messages. ### Does this PR introduce _any_ user-facing change? Yes. The PR changes user-facing error messages. ### How was this patch tested? Pass GitHub Actions Closes apache#38705 from LuciferYang/SPARK-41173. Authored-by: yangjie01 <[email protected]> Signed-off-by: Max Gekk <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…ng expressions ### What changes were proposed in this pull request? This pr aims to move `require()` out from the constructors of string expressions, include `ConcatWs` and `FormatString`. The args number checking logic moved into `checkInputDataTypes()`. ### Why are the changes needed? Migration onto error classes unifies Spark SQL error messages. ### Does this PR introduce _any_ user-facing change? Yes. The PR changes user-facing error messages. ### How was this patch tested? Pass GitHub Actions Closes apache#38705 from LuciferYang/SPARK-41173. Authored-by: yangjie01 <[email protected]> Signed-off-by: Max Gekk <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…ng expressions ### What changes were proposed in this pull request? This pr aims to move `require()` out from the constructors of string expressions, include `ConcatWs` and `FormatString`. The args number checking logic moved into `checkInputDataTypes()`. ### Why are the changes needed? Migration onto error classes unifies Spark SQL error messages. ### Does this PR introduce _any_ user-facing change? Yes. The PR changes user-facing error messages. ### How was this patch tested? Pass GitHub Actions Closes apache#38705 from LuciferYang/SPARK-41173. Authored-by: yangjie01 <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to move
require()out from the constructors of string expressions, includeConcatWsandFormatString.The args number checking logic moved into
checkInputDataTypes().Why are the changes needed?
Migration onto error classes unifies Spark SQL error messages.
Does this PR introduce any user-facing change?
Yes. The PR changes user-facing error messages.
How was this patch tested?
Pass GitHub Actions