[SPARK-41003][SQL] BHJ LeftAnti does not update numOutputRows when codegen is disabled #38489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Currentenable codegen
disable codegen
Fix
|
|
Can one of the admins verify this patch? |
Contributor
Author
|
Help review. Thanks. |
Contributor
Author
|
Help review. Thanks. @HyukjinKwon @yaooqinn |
Contributor
|
Can we add a test in |
Member
+1 |
Contributor
Author
|
Add UT. CurrentFix |
cloud-fan
reviewed
Nov 25, 2022
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 25, 2022
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
Outdated
Show resolved
Hide resolved
Contributor
|
thanks, merging to master! |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…degen is disabled ### What changes were proposed in this pull request? BHJ LeftAnti does not update numOutputRows when codegen is disabled ### Why are the changes needed? PR apache#29104 Only update numOutputRows when codegen is enabled, but there is no numOutputRows when codegen is disabled, and numOutputRows is equal to 0. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? add UT Closes apache#38489 from cxzl25/SPARK-41003. Authored-by: sychen <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…degen is disabled ### What changes were proposed in this pull request? BHJ LeftAnti does not update numOutputRows when codegen is disabled ### Why are the changes needed? PR apache#29104 Only update numOutputRows when codegen is enabled, but there is no numOutputRows when codegen is disabled, and numOutputRows is equal to 0. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? add UT Closes apache#38489 from cxzl25/SPARK-41003. Authored-by: sychen <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
BHJ LeftAnti does not update numOutputRows when codegen is disabled
Why are the changes needed?
PR #29104 Only update numOutputRows when codegen is enabled, but there is no numOutputRows when codegen is disabled, and numOutputRows is equal to 0.
Does this PR introduce any user-facing change?
No
How was this patch tested?
add UT