Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 1, 2022

What changes were proposed in this pull request?

This PR aims to update cloudpickle to v2.2.0 for Apache Spark 3.4.0.

Why are the changes needed?

SPARK-37457 updated cloudpickle v2.0.0 at Apache Spark 3.3.0.

To bring the latest bug fixes.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-XXX][PYTHON] Update cloudpickle to v2.2.0 [SPARK-XXX][PYTHON] Update cloudpickle to v2.2.0 Nov 1, 2022
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-XXX][PYTHON] Update cloudpickle to v2.2.0 [SPARK-40991][PYTHON] Update cloudpickle to v2.2.0 Nov 1, 2022
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we should copy and paste this file too https://github.com/cloudpipe/cloudpickle/blob/master/cloudpickle/cloudpickle_fast.py and __init__.py (see also #31007).

A couple of minor changes in the import is required too, e.g.)

from pyspark.cloudpickle.cloudpickle import *  # noqa
from pyspark.cloudpickle.cloudpickle_fast import CloudPickler, dumps, dump  # noqa

in __init__.py IIRC

@itholic
Copy link
Contributor

itholic commented Nov 2, 2022

+1 for upgrading the cloudpickle version

@dongjoon-hyun
Copy link
Member Author

Thank you for review, @HyukjinKwon and @itholic .

@HyukjinKwon
Copy link
Member

Merged to master.

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @HyukjinKwon !

@dongjoon-hyun dongjoon-hyun deleted the SPARK-40991 branch November 2, 2022 06:06
SandishKumarHN pushed a commit to SandishKumarHN/spark that referenced this pull request Dec 12, 2022
### What changes were proposed in this pull request?

This PR aims to update `cloudpickle` to `v2.2.0` for Apache Spark 3.4.0.

### Why are the changes needed?

SPARK-37457 updated `cloudpickle` v2.0.0 at Apache Spark 3.3.0.

To bring the latest bug fixes.
- https://github.com/cloudpipe/cloudpickle/releases/tag/v2.2.0
- https://github.com/cloudpipe/cloudpickle/releases/tag/2.1.0

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes apache#38474 from dongjoon-hyun/SPARK-40991.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants