[SPARK-33983][PYTHON] Update cloudpickle to v1.6.0 #31007
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
reviewed
Jan 4, 2021
|
|
||
| # Declaring a function inside another one using the "def ..." | ||
| # syntax generates a constant code object corresponding to the one | ||
| # syntax generates a constant code object corresonding to the one |
Member
Author
There was a problem hiding this comment.
Its a copy from cloudpickle. I think I would just keep it as is.
Member
Author
There was a problem hiding this comment.
cloudpipe/cloudpickle#406. Let's fix it back when we upgrade next time.
MaxGekk
reviewed
Jan 4, 2021
|
|
||
| # Track the provenance of reconstructed dynamic classes to make it possible to | ||
| # reconstruct instances from the matching singleton class definition when | ||
| # recontruct instances from the matching singleton class definition when |
MaxGekk
requested changes
Jan 4, 2021
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
Could you re-check all changes in comments.
dongjoon-hyun
approved these changes
Jan 4, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. I also agree with @HyukjinKwon . We had better fix the upstream and keep our fork as a plain copy.
Historically, 13fd272 fixed the typos here. I'm okay to lose the typo corrections.
Thank you, @HyukjinKwon and @MaxGekk . Merged to master for Apache Spark 3.2.0.
Member
Author
|
Thanks @MaxGekk and @dongjoon-hyun ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to upgrade cloudpickle from 1.5.0 to 1.6.0.
It virtually contains one fix:
cloudpipe/cloudpickle@4510be8
From a cursory look, this isn't a regression, and not even properly supported in Python:
So it seems fine not to backport.
Why are the changes needed?
To leverage bug fixes from the cloudpickle upstream.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Jenkins build and GitHub actions build will test it out.