[SPARK-39778][SQL] Improve error classes and messages #38398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
referenced
this pull request
Oct 26, 2022
### What changes were proposed in this pull request? The pr aim to Update the error template of WRONG_NUM_PARAMS. ### Why are the changes needed? More general. ### Does this PR introduce _any_ user-facing change? Yes the PR changes user-facing error messages. ### How was this patch tested? - Existed UT. - Pass GA. Closes #38319 from panbingkun/update_WRONG_NUM_PARAMS_template. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
MaxGekk
changed the title
MaxGekk
changed the title
Member
Author
MaxGekk
commented
Oct 27, 2022
| ] | ||
| }, | ||
| "WRONG_NUM_ENDPOINTS" : { | ||
| "WRONG_NUM_ARGS" : { |
Member
Author
There was a problem hiding this comment.
@srielau FYI, I addressed your comment dece380#r87901056
itholic
approved these changes
Oct 27, 2022
cloud-fan
approved these changes
Oct 28, 2022
Member
Author
|
Merging to master. Thank you, @itholic @cloud-fan for review. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? 1. Remove unused error classes: INCONSISTENT_BEHAVIOR_CROSS_VERSION.FORMAT_DATETIME_BY_NEW_PARSER, NAMESPACE_ALREADY_EXISTS, NAMESPACE_NOT_EMPTY, NAMESPACE_NOT_FOUND. 2. Rename the error class WRONG_NUM_PARAMS to WRONG_NUM_ARGS. 3. Use correct error class INDEX_ALREADY_EXISTS in the exception `IndexAlreadyExistsException` instead of INDEX_NOT_FOUND. 4. Quote regexp patterns by ''. 5. Fix indentations in [QueryCompilationErrors.scala](https://github.com/apache/spark/pull/38398/files#diff-744ac13f6fe074fddeab09b407404bffa2386f54abc83c501e6e1fe618f6db56). ### Why are the changes needed? To address tech debts. ### Does this PR introduce _any_ user-facing change? Yes, it modifies user-facing error messages. ### How was this patch tested? By running the modified test suites: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" $ build/sbt "test:testOnly *SQLQuerySuite" $ build/sbt "test:testOnly *StringExpressionsSuite" $ build/sbt "test:testOnly *.RegexpExpressionsSuite" ``` Closes apache#38398 from MaxGekk/remove-unused-error-classes. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
IndexAlreadyExistsExceptioninstead of INDEX_NOT_FOUND.Why are the changes needed?
To address tech debts.
Does this PR introduce any user-facing change?
Yes, it modifies user-facing error messages.
How was this patch tested?
By running the modified test suites: