[SPARK-40856][SQL] Update the error template of WRONG_NUM_PARAMS #38319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
reviewed
Oct 20, 2022
| messageParameters = Map("actualNum" -> children.length.toString)) | ||
| messageParameters = Map( | ||
| "functionName" -> prettyName, | ||
| "expectedNum" -> "at least two", |
Member
There was a problem hiding this comment.
Let's pass > 1 instead of at least two to don't depend on English. When we will translate error-classes.json to a local language, it would be nice to avoid error messages in different languages.
|
Can one of the admins verify this patch? |
Member
|
@panbingkun Seems like a connection issue: Could you re-trigger GAs, please. |
Contributor
Author
Done |
MaxGekk
approved these changes
Oct 22, 2022
Member
|
+1, LGTM. Merging to master. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? The pr aim to Update the error template of WRONG_NUM_PARAMS. ### Why are the changes needed? More general. ### Does this PR introduce _any_ user-facing change? Yes the PR changes user-facing error messages. ### How was this patch tested? - Existed UT. - Pass GA. Closes apache#38319 from panbingkun/update_WRONG_NUM_PARAMS_template. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aim to Update the error template of WRONG_NUM_PARAMS.
Why are the changes needed?
More general.
Does this PR introduce any user-facing change?
Yes the PR changes user-facing error messages.
How was this patch tested?