-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-40899] [CONNECT] Make UserContext extensible. #38374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
...nect/src/test/scala/org/apache/spark/sql/connect/messages/ConnectProtoMessagesSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.spark.sql.connect.messages | ||
|
|
||
| import org.apache.spark.SparkFunSuite | ||
| import org.apache.spark.connect.proto | ||
|
|
||
| class ConnectProtoMessagesSuite extends SparkFunSuite { | ||
| test("UserContext can deal with extensions") { | ||
| // Create the builder. | ||
| val builder = proto.Request.UserContext.newBuilder().setUserId("1").setUserName("Martin") | ||
|
|
||
| // Create the extension value. | ||
| val lit = proto.Expression | ||
| .newBuilder() | ||
| .setLiteral(proto.Expression.Literal.newBuilder().setI32(32).build()) | ||
| // Pack the extension into Any. | ||
| val aval = com.google.protobuf.Any.pack(lit.build()) | ||
| // Add Any to the repeated field list. | ||
| builder.addExtensions(aval) | ||
| // Create serialized value. | ||
| val serialized = builder.build().toByteArray | ||
|
|
||
| // Now, read the serialized value. | ||
| val result = proto.Request.UserContext.parseFrom(serialized) | ||
| assert(result.getUserId.equals("1")) | ||
| assert(result.getUserName.equals("Martin")) | ||
| assert(result.getExtensionsCount == 1) | ||
|
|
||
| val ext = result.getExtensions(0) | ||
| assert(ext.is(classOf[proto.Expression])) | ||
| val extLit = ext.unpack(classOf[proto.Expression]) | ||
| assert(extLit.hasLiteral) | ||
| assert(extLit.getLiteral.hasI32) | ||
| assert(extLit.getLiteral.getI32 == 32) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my self education:
Is Any type potentially a cause of security holes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No any is just used to define extension points in the proto so that at the point of writing the proto we don't need to define message that is embedded in the proto.
Interpreting the serialized class is up to the consumer and follows the same security model as any other serialized code so we have to be careful but it's not a new threat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Makes sense.