[SPARK-40899] [CONNECT] Make UserContext extensible. #38374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
cloud-fan
approved these changes
Oct 24, 2022
amaliujia
reviewed
Oct 24, 2022
| // Spark Connect leverages the Any protobuf type that can be used to inject arbitrary other | ||
| // messages into this message. Extensions are stored as a `repeated` type to be able to | ||
| // handle multiple active extensions. | ||
| repeated google.protobuf.Any extensions = 999; |
Contributor
There was a problem hiding this comment.
Just for my self education:
Is Any type potentially a cause of security holes?
Contributor
Author
There was a problem hiding this comment.
No any is just used to define extension points in the proto so that at the point of writing the proto we don't need to define message that is embedded in the proto.
Interpreting the serialized class is up to the consumer and follows the same security model as any other serialized code so we have to be careful but it's not a new threat.
amaliujia
reviewed
Oct 24, 2022
Contributor
amaliujia
left a comment
amaliujia
left a comment
There was a problem hiding this comment.
LGTM
Only left an open question.
|
Can one of the admins verify this patch? |
HyukjinKwon
approved these changes
Oct 25, 2022
Contributor
|
thanks, merging to master! |
DeZepTup
pushed a commit
to DeZepTup/spark-custom
that referenced
this pull request
Oct 31, 2022
Different systems will need different metadata that is passed as the user context during the request. To be able to handle the different systems seamlessly, make the `UserContext` extensible with `google.protobuf.Any`. Extensibility. No UT Closes apache#38374 from grundprinzip/SPARK-40899. Authored-by: Martin Grund <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? Different systems will need different metadata that is passed as the user context during the request. To be able to handle the different systems seamlessly, make the `UserContext` extensible with `google.protobuf.Any`. ### Why are the changes needed? Extensibility. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38374 from grundprinzip/SPARK-40899. Authored-by: Martin Grund <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Different systems will need different metadata that is passed as the user context during the request. To be able to handle the different systems seamlessly, make the
UserContextextensible withgoogle.protobuf.Any.Why are the changes needed?
Extensibility.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT