Skip to content

Conversation

@Yikun
Copy link
Member

@Yikun Yikun commented Oct 23, 2022

What changes were proposed in this pull request?

Upgrade actions/cache to v3 and actions/upload-artifact to v3

Why are the changes needed?

  • Since actions/cache@v3: support from node 12 -> node 16 and cleanup set-output warning
  • Since actions/upload-artifact@v3: support from node 12 -> node 16 and cleanup set-output warning

Does this PR introduce any user-facing change?

No, dev only

How was this patch tested?

CI passed

@github-actions github-actions bot added the INFRA label Oct 23, 2022
@srowen
Copy link
Member

srowen commented Oct 23, 2022

Looks OK if tests pass; looks like an unrelated error:

RUN: /__w/spark/spark/connector/connect/dev/generate_protos.sh /tmp/tmpvqg44rqj
Different files: ['base_pb2.pyi', 'commands_pb2.pyi', 'expressions_pb2.pyi', 'relations_pb2.pyi', 'types_pb2.pyi']
Generated files for pyspark-connect are out of sync! If you have touched files under connector/connect/src/main/protobuf, please run ./connector/connect/dev/generate_protos.sh. If you haven't touched any file above, please rebase your PR against main branch.
Error: Process completed with exit code 255.

@Yikun
Copy link
Member Author

Yikun commented Oct 24, 2022

@srowen Thanks, might be rebase issue. Let me do a rebase.

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@Yikun
Copy link
Member Author

Yikun commented Oct 24, 2022

image

CI passed, will merge soon

@Yikun Yikun closed this in c721c72 Oct 24, 2022
@Yikun
Copy link
Member Author

Yikun commented Oct 24, 2022

@srowen @LuciferYang Thanks, merged to master (3.4.0).

SandishKumarHN pushed a commit to SandishKumarHN/spark that referenced this pull request Dec 12, 2022
…rtifact to v3

### What changes were proposed in this pull request?
Upgrade actions/cache to v3 and actions/upload-artifact to v3

### Why are the changes needed?
- Since actions/cachev3: support from node 12 -> node 16 and cleanup `set-output` warning
- Since actions/upload-artifactv3: support from node 12 -> node 16 and cleanup `set-output` warning

### Does this PR introduce _any_ user-facing change?
No, dev only

### How was this patch tested?
CI passed

Closes apache#38353 from Yikun/SPARK-40881.

Authored-by: Yikun Jiang <[email protected]>
Signed-off-by: Yikun Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants