Skip to content

[SPARK-40696][INFRA][FOLLOWUP] Add packages write permisson for parent workflows#38145

Closed
Yikun wants to merge 1 commit intoapache:masterfrom
Yikun:SPARK-40696-FOLLOWUP
Closed

[SPARK-40696][INFRA][FOLLOWUP] Add packages write permisson for parent workflows#38145
Yikun wants to merge 1 commit intoapache:masterfrom
Yikun:SPARK-40696-FOLLOWUP

Conversation

@Yikun
Copy link
Member

@Yikun Yikun commented Oct 7, 2022

What changes were proposed in this pull request?

Add packages write permisson for parent workflows

Why are the changes needed?

To avoid the issue like:

The workflow is not valid. .github/workflows/build_main.yml (Line: 28, Col: 3): Error calling workflow 'apache/spark/.github/workflows/build_and_test.yml@6eedb0e'. The nested job 'Base image build' is requesting 'packages: write', but is only allowed 'packages: none'.

https://github.com/apache/spark/actions/runs/3202259476/workflow

Does this PR introduce any user-facing change?

No, dev only

How was this patch tested?

see master merge results.

@Yikun
Copy link
Member Author

Yikun commented Oct 7, 2022

cc @HyukjinKwon

@Yikun
Copy link
Member Author

Yikun commented Oct 7, 2022

wait until base image job passed

@Yikun
Copy link
Member Author

Yikun commented Oct 7, 2022

@HyukjinKwon
Copy link
Member

Merged to master.

@Yikun
Copy link
Member Author

Yikun commented Oct 7, 2022

@HyukjinKwon

From the latest merged commit CI result, work as execpected!
https://github.com/apache/spark/actions/runs/3202391656/jobs/5231332667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants