Skip to content

[SPARK-40696][INFRA] Add packages write permisson for infra image#38144

Closed
Yikun wants to merge 1 commit intoapache:masterfrom
Yikun:SPARK-40695
Closed

[SPARK-40696][INFRA] Add packages write permisson for infra image#38144
Yikun wants to merge 1 commit intoapache:masterfrom
Yikun:SPARK-40695

Conversation

@Yikun
Copy link
Member

@Yikun Yikun commented Oct 7, 2022

What changes were proposed in this pull request?

This patch add the write permission for infra image related jobs.

Why are the changes needed?

In princinple, the default github action token permissons already contains enough permissions, but looks like it failed due to some reason recently (but I haven't noticed any github official changes log yet and apache infra notification)

Does this PR introduce any user-facing change?

No, dev only

How was this patch tested?

  • CI passed.
  • After merge, the master job recover.

@Yikun Yikun changed the title Add packages write permisson for infra image [WIP] Add packages write permisson for infra image Oct 7, 2022
@github-actions github-actions bot added the INFRA label Oct 7, 2022
@Yikun Yikun marked this pull request as draft October 7, 2022 03:03
@Yikun Yikun changed the title [WIP] Add packages write permisson for infra image [SPARK-40696][INFRA] Add packages write permisson for infra image Oct 7, 2022
@HyukjinKwon HyukjinKwon marked this pull request as ready for review October 7, 2022 04:27
@HyukjinKwon
Copy link
Member

Let's see how it goes.

Merged to master.

@Yikun
Copy link
Member Author

Yikun commented Oct 7, 2022

@HyukjinKwon Thanks!

The workflow is not valid. .github/workflows/build_main.yml (Line: 28, Col: 3): Error calling workflow 'apache/spark/.github/workflows/build_and_test.yml@6eedb0e'. The nested job 'Base image build' is requesting 'packages: write', but is only allowed 'packages: none'.

https://github.com/apache/spark/actions/runs/3202259476/workflow

Looks like cache job works as exepceted, and workflow call job needs a followup: #38145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments