[SPARK-40423][K8S][TESTS] Add explicit YuniKorn queue submission test coverage #37877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Sep 14, 2022
| ```bash | ||
| --conf spark.kubernetes.scheduler.name=yunikorn | ||
| --conf spark.kubernetes.driver.label.queue=root.default | ||
| --conf spark.kubernetes.executor.label.queue=root.default |
Member
Author
There was a problem hiding this comment.
Apache YuniKorn provides two ways to set queues. We choose the simpler one.
dongjoon-hyun
commented
Sep 14, 2022
| helm repo update | ||
| kubectl create namespace yunikorn | ||
| helm install yunikorn yunikorn/yunikorn --namespace yunikorn --version 1.1.0 | ||
| helm install yunikorn yunikorn/yunikorn --namespace yunikorn --version 1.1.0 --create-namespace --set embedAdmissionController=false |
Member
Author
There was a problem hiding this comment.
We should not install YuniKorn admission controller because it doesn't allow other schedulers by default.
Member
Author
|
Could you review this when you have some time, @viirya ? |
martin-g
approved these changes
Sep 14, 2022
viirya
approved these changes
Sep 14, 2022
Member
Author
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 14, 2022
… coverage ### What changes were proposed in this pull request? This PR aims to add explicit Yunikorn queue submission test coverage instead of implicit assignment by admission controller. ### Why are the changes needed? - To provide a proper test coverage. - To prevent the side effect of YuniKorn admission controller which overrides all Spark's scheduler settings by default (if we do not edit the rule explicitly). This breaks Apache Spark's default scheduler K8s IT test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually run the CI and check the YuniKorn queue UI. ``` $ build/sbt -Psparkr -Pkubernetes -Pkubernetes-integration-tests -Dspark.kubernetes.test.deployMode=docker-desktop "kubernetes-integration-tests/test" -Dtest.exclude.tags=minikube,local,decom -Dtest.default.exclude.tags= ``` <img width="1197" alt="Screen Shot 2022-09-14 at 2 07 38 AM" src="https://user-images.githubusercontent.com/9700541/190112005-5863bdd3-2e43-4ec7-b34b-a286d1a7c95e.png"> Closes #37877 from dongjoon-hyun/SPARK-40423. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 12e4852) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add explicit Yunikorn queue submission test coverage instead of implicit assignment by admission controller.
Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually run the CI and check the YuniKorn queue UI.