Skip to content

[SPARK-40324][SQL][FOLLOWUP] Fix a bug in setting query context in Analyzer #37861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gengliangwang wants to merge 9 commits into from
Closed

[SPARK-40324][SQL][FOLLOWUP] Fix a bug in setting query context in Analyzer #37861

gengliangwang wants to merge 9 commits into from

Conversation

@gengliangwang
Copy link
Member

@gengliangwang gengliangwang commented Sep 13, 2022

What changes were proposed in this pull request?

This is a followup of #37841. The code change in https://github.com/apache/spark/pull/37841/files#diff-ed19f376a63eba52eea59ca71f3355d4495fad4fad4db9a3324aade0d4986a47R212 is wrong. The context ofanalyzed.origin is not accurate at all. Thus this PR is to revert it

Why are the changes needed?

Fix a wrong query context in previous PR #37841

Does this PR introduce any user-facing change?

No

How was this patch tested?

GA tests

@github-actions github-actions bot added the SQL label Sep 13, 2022
@gengliangwang
Copy link
Member Author

gengliangwang commented Sep 13, 2022 •
edited
Loading

For throwing AnalysisException, we should use the method

    def failAnalysis(errorClass: String, messageParameters: Array[String]): Nothing = {
      throw new AnalysisException(
        errorClass = errorClass,
        messageParameters = messageParameters,
        origin = t.origin)
    }

or similar approaches.
For example: #37811 (comment)

MaxGekk
MaxGekk reviewed Sep 13, 2022
View reviewed changes
sql/core/src/test/resources/sql-tests/results/group-by-filter.sql.out
Comment on lines -236 to -243
},
"queryContext" : [ {
"objectType" : "",
"objectName" : "",
"startIndex" : 56,
"stopIndex" : 65,
"fragment" : "GROUP BY b"
} ]
Copy link
Member

@MaxGekk MaxGekk Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the context disappear completely?

Copy link
Member Author

@gengliangwang gengliangwang Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously it is set as analyzed.origin which is wrong. It should point to a instead of GROUP BY b anyway.

@gengliangwang
Copy link
Member Author

gengliangwang commented Sep 14, 2022

@cloud-fan @MaxGekk Thanks for the review. Merging this one to master.

This was referenced Sep 14, 2022
Closed
Closed
@MaxGekk MaxGekk mentioned this pull request Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxGekk MaxGekk MaxGekk left review comments

@cloud-fan cloud-fan cloud-fan approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gengliangwang @MaxGekk @cloud-fan