[SPARK-40070][BUILD] Upgrade Apache ZooKeeper to 3.8.0
#37507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
reviewed
Aug 13, 2022
| log4j-api/2.18.0//log4j-api-2.18.0.jar | ||
| log4j-core/2.18.0//log4j-core-2.18.0.jar | ||
| log4j-slf4j-impl/2.18.0//log4j-slf4j-impl-2.18.0.jar | ||
| logback-classic/1.2.10//logback-classic-1.2.10.jar |
Contributor
There was a problem hiding this comment.
Won't this conflict with log4j2?
LuciferYang
reviewed
Aug 13, 2022
| @@ -206,6 +208,7 @@ netty-common/4.1.77.Final//netty-common-4.1.77.Final.jar | |||
| netty-handler/4.1.77.Final//netty-handler-4.1.77.Final.jar | |||
| netty-resolver/4.1.77.Final//netty-resolver-4.1.77.Final.jar | |||
| netty-tcnative-classes/2.0.52.Final//netty-tcnative-classes-2.0.52.Final.jar | |||
Contributor
There was a problem hiding this comment.
What is the difference between netty-tcnative-classes and netty-tcnative? netty 4.1.77 requires netty-tcnative-classes 2.0.52.Final
Contributor
|
@bjornjorgensen Could you do some manually test using Maven with |
Contributor
Author
|
@LuciferYang Thank you. I have just run "ZooKeeper clients from 3.5.x onwards are fully compatible with 3.8.x servers. The upgrade from 3.6.x and 3.7.x can be executed as usual, no particular additional upgrade procedure is needed. ZooKeeper 3.8.x clients are compatible with 3.5.x, 3.6.x and 3.7.x servers as long as you are not using new APIs not present these versions." But should we upgrade to 3.6.3? or 3.7 or? |
yaooqinn
added a commit
that referenced
this pull request
Nov 21, 2022
### What changes were proposed in this pull request? Upgrade ZooKeeper to 3.6.3 ### Why are the changes needed? ZooKeeper 3.6.3 contains many bugfixes, such as a thread leak issue described in ZOOKEEPER-3706. FYI, https://zookeeper.apache.org/doc/r3.6.3/releasenotes.html - Why is 3.6.3 but not higher? - #37507 - #32572 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests and dependency check Closes #38733 from yaooqinn/SPARK-41211. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]>
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? Upgrade ZooKeeper to 3.6.3 ### Why are the changes needed? ZooKeeper 3.6.3 contains many bugfixes, such as a thread leak issue described in ZOOKEEPER-3706. FYI, https://zookeeper.apache.org/doc/r3.6.3/releasenotes.html - Why is 3.6.3 but not higher? - apache#37507 - apache#32572 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests and dependency check Closes apache#38733 from yaooqinn/SPARK-41211. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
### What changes were proposed in this pull request? Upgrade ZooKeeper to 3.6.3 ### Why are the changes needed? ZooKeeper 3.6.3 contains many bugfixes, such as a thread leak issue described in ZOOKEEPER-3706. FYI, https://zookeeper.apache.org/doc/r3.6.3/releasenotes.html - Why is 3.6.3 but not higher? - apache#37507 - apache#32572 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests and dependency check Closes apache#38733 from yaooqinn/SPARK-41211. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? Upgrade ZooKeeper to 3.6.3 ### Why are the changes needed? ZooKeeper 3.6.3 contains many bugfixes, such as a thread leak issue described in ZOOKEEPER-3706. FYI, https://zookeeper.apache.org/doc/r3.6.3/releasenotes.html - Why is 3.6.3 but not higher? - apache#37507 - apache#32572 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests and dependency check Closes apache#38733 from yaooqinn/SPARK-41211. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade Apache ZooKeeper from 3.6.2 to 3.8.0
Why are the changes needed?
SNYK want to Upgrade org.apache.zookeeper:zookeeper from 3.6.2 to 3.8.0
The recommended version is 4 versions ahead of your current version.
The recommended version was released 5 months ago, on 2022-02-25.
Releases notes.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.