Skip to content

[SPARK-35305][BUILD] Upgrade Zookeeper to 3.7.0#32572

Closed
zhulipeng wants to merge 2 commits intoapache:masterfrom
zhulipeng:SPARK-35305
Closed

[SPARK-35305][BUILD] Upgrade Zookeeper to 3.7.0#32572
zhulipeng wants to merge 2 commits intoapache:masterfrom
zhulipeng:SPARK-35305

Conversation

@zhulipeng
Copy link
Contributor

What changes were proposed in this pull request?

Upgrade zookeeper to 3.7.0.

Why are the changes needed?

Upgrade ZooKeeper to 3.7.0 to fix the vulnerabilities.

List of CVE's:

CVE-2021-21295
CVE-2021-21290
CVE-2021-21409

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Exists UT.

@github-actions github-actions bot added the BUILD label May 17, 2021
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Copy link
Member

@wangyum wangyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the dependencies:

./dev/test-dependencies.sh --replace-manifest

@srowen
Copy link
Member

srowen commented May 17, 2021

Does this present any compatibility concerns with Hadoop 3.2?

@dongjoon-hyun
Copy link
Member

Are those CVE applicable to Zookeeper Client , @lipzhu ?

@zhulipeng
Copy link
Contributor Author

Are those CVE applicable to Zookeeper Client , @lipzhu ?

Found https://issues.apache.org/jira/browse/ZOOKEEPER-4278 https://issues.apache.org/jira/browse/ZOOKEEPER-4272
But didn't affect zookeeper 3.7.0 version.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointers. I checked those Zookeeper JIRA issues and CVEs.

Apache Spark is using netty-all 4.1.63.Final. Isn't it enough?

@zhulipeng
Copy link
Contributor Author

Yes, you are right, the list CVE were resolved by netty-all 4.1.63.Final.
For zookeeper, version 3.6.3 https://zookeeper.apache.org/doc/r3.6.3/releasenotes.html includes the CVE fix instead of version 3.7.0.

@zhulipeng zhulipeng closed this May 18, 2021
@dongjoon-hyun
Copy link
Member

Thank you for closing, @lipzhu .

yaooqinn added a commit that referenced this pull request Nov 21, 2022
### What changes were proposed in this pull request?

Upgrade ZooKeeper to 3.6.3

### Why are the changes needed?

ZooKeeper 3.6.3 contains many bugfixes, such as a thread leak issue described in ZOOKEEPER-3706.

FYI, https://zookeeper.apache.org/doc/r3.6.3/releasenotes.html

- Why is 3.6.3 but not higher?
  - #37507
  - #32572

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

existing tests and dependency check

Closes #38733 from yaooqinn/SPARK-41211.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Kent Yao <yao@apache.org>
SandishKumarHN pushed a commit to SandishKumarHN/spark that referenced this pull request Dec 12, 2022
### What changes were proposed in this pull request?

Upgrade ZooKeeper to 3.6.3

### Why are the changes needed?

ZooKeeper 3.6.3 contains many bugfixes, such as a thread leak issue described in ZOOKEEPER-3706.

FYI, https://zookeeper.apache.org/doc/r3.6.3/releasenotes.html

- Why is 3.6.3 but not higher?
  - apache#37507
  - apache#32572

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

existing tests and dependency check

Closes apache#38733 from yaooqinn/SPARK-41211.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Kent Yao <yao@apache.org>
beliefer pushed a commit to beliefer/spark that referenced this pull request Dec 15, 2022
### What changes were proposed in this pull request?

Upgrade ZooKeeper to 3.6.3

### Why are the changes needed?

ZooKeeper 3.6.3 contains many bugfixes, such as a thread leak issue described in ZOOKEEPER-3706.

FYI, https://zookeeper.apache.org/doc/r3.6.3/releasenotes.html

- Why is 3.6.3 but not higher?
  - apache#37507
  - apache#32572

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

existing tests and dependency check

Closes apache#38733 from yaooqinn/SPARK-41211.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Kent Yao <yao@apache.org>
beliefer pushed a commit to beliefer/spark that referenced this pull request Dec 18, 2022
### What changes were proposed in this pull request?

Upgrade ZooKeeper to 3.6.3

### Why are the changes needed?

ZooKeeper 3.6.3 contains many bugfixes, such as a thread leak issue described in ZOOKEEPER-3706.

FYI, https://zookeeper.apache.org/doc/r3.6.3/releasenotes.html

- Why is 3.6.3 but not higher?
  - apache#37507
  - apache#32572

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

existing tests and dependency check

Closes apache#38733 from yaooqinn/SPARK-41211.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants