Skip to content

[SPARK-39963][SQL][TESTS][FOLLOW-UP] Disable ANSI mode for test of casting date to decimal #37426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 1 commit into from
Closed

[SPARK-39963][SQL][TESTS][FOLLOW-UP] Disable ANSI mode for test of casting date to decimal #37426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyCastsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import org.apache.spark.sql.catalyst.dsl.plans._
import org.apache.spark.sql.catalyst.plans.PlanTest
import org.apache.spark.sql.catalyst.plans.logical._
import org.apache.spark.sql.catalyst.rules.RuleExecutor
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._

class SimplifyCastsSuite extends PlanTest {
Expand Down Expand Up @@ -95,10 +96,17 @@ class SimplifyCastsSuite extends PlanTest {
Optimize.execute(
input.select($"b".cast(DecimalType(10, 2)).cast(DecimalType(24, 2)).as("casted")).analyze),
input.select($"b".cast(DecimalType(10, 2)).cast(DecimalType(24, 2)).as("casted")).analyze)
comparePlans(
Optimize.execute(
input.select($"c".cast(DecimalType(10, 2)).cast(DecimalType(24, 2)).as("casted")).analyze),
input.select($"c".cast(DecimalType(10, 2)).cast(DecimalType(24, 2)).as("casted")).analyze)

withClue("SPARK-39963: cast date to decimal") {
withSQLConf(SQLConf.ANSI_ENABLED.key -> false.toString) {
// ANSI mode does not allow to cast a date to a decimal.
comparePlans(Optimize.execute(
input.select(
$"c".cast(DecimalType(10, 2)).cast(DecimalType(24, 2)).as("casted")).analyze),
input.select(
$"c".cast(DecimalType(10, 2)).cast(DecimalType(24, 2)).as("casted")).analyze)
}
}

comparePlans(
Optimize.execute(
Expand Down