Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a followup of #37389 which disables ANSI mode when testing a case from date to decimal.

Why are the changes needed?

To make the test pass. Currently it fails with ANSI mode on, see also https://github.com/apache/spark/runs/7701218236?check_suite_focus=true.

Does this PR introduce any user-facing change?

No, test-only.

How was this patch tested?

I manually ran the test in my local.

@HyukjinKwon
Copy link
Member Author

cc @cloud-fan and @beliefer

@github-actions github-actions bot added the SQL label Aug 6, 2022
@gengliangwang
Copy link
Member

Thanks, merging to master

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. late LGTM.

@HyukjinKwon HyukjinKwon deleted the SPARK-39963 branch January 15, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants