Skip to content

Conversation

@Yikun
Copy link
Member

@Yikun Yikun commented Aug 4, 2022

What changes were proposed in this pull request?

Create separate static image tag for infra static image

Why are the changes needed?

Currently, we put the static image and cache together in same tag like ghcr.io/apache/spark/apache-spark-github-action-image-cache:master.

Cache and static image occupy separate different image hash and same image tags. this bring some problem in below cases:

  • Debug job with static docker images, they have to find hash. If use cache directly, will raise something like:
yikun-x86:~# docker run -ti ghcr.io/yikun/apache-spark-github-action-image-cache:master
Unable to find image 'ghcr.io/yikun/apache-spark-github-action-image-cache:master' locally
master: Pulling from yikun/apache-spark-github-action-image-cache
docker: no matching manifest for linux/amd64 in the manifest list entries.
  • Use static image in CI, such as for some reason we want to switch static image temporarily.
  • Easy to see history for last cache, such as system deps/lib.

Does this PR introduce any user-facing change?

No

How was this patch tested?

root@yikun-x86:~# docker run -ti ghcr.io/yikun/apache-spark-github-action-image-cache:master-static
Unable to find image 'ghcr.io/yikun/apache-spark-github-action-image-cache:master-static' locally
master-static: Pulling from yikun/apache-spark-github-action-image-cache
Digest: sha256:5198fd8111c925b7c92d04427268bcb0e5574bb72cef09808076595f3372bf7b
Status: Downloaded newer image for ghcr.io/yikun/apache-spark-github-action-image-cache:master-static
root@3550e09e0e93:/# exit

@Yikun Yikun marked this pull request as ready for review August 4, 2022 06:15
@Yikun
Copy link
Member Author

Yikun commented Aug 4, 2022

Ready to go.

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants