Add static image #144
Closed
Add static image #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
pushed a commit
to apache/spark
that referenced
this pull request
Aug 4, 2022
### What changes were proposed in this pull request? Create separate static image tag for infra static image ### Why are the changes needed? Currently, we put the **static image** and **cache** together in same tag like [`ghcr.io/apache/spark/apache-spark-github-action-image-cache:master`](https://github.com/apache/spark/pkgs/container/spark%2Fapache-spark-github-action-image-cache/versions). Cache and static image occupy separate different image hash and same image tags. this bring some problem in below cases: - **Debug job with static docker images**, they have to find hash. If use cache directly, will raise something like: ``` yikun-x86:~# docker run -ti ghcr.io/yikun/apache-spark-github-action-image-cache:master Unable to find image 'ghcr.io/yikun/apache-spark-github-action-image-cache:master' locally master: Pulling from yikun/apache-spark-github-action-image-cache docker: no matching manifest for linux/amd64 in the manifest list entries. ``` - **Use static image in CI**, such as for some reason we want to switch static image temporarily. - **Easy to see history for last cache**, such as system deps/lib. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Local test: Yikun#144, and static image tag push [passed](https://github.com/Yikun/spark/runs/7664266955?check_suite_focus=true#step:6:212) - Run static image: ``` rootyikun-x86:~# docker run -ti ghcr.io/yikun/apache-spark-github-action-image-cache:master-static Unable to find image 'ghcr.io/yikun/apache-spark-github-action-image-cache:master-static' locally master-static: Pulling from yikun/apache-spark-github-action-image-cache Digest: sha256:5198fd8111c925b7c92d04427268bcb0e5574bb72cef09808076595f3372bf7b Status: Downloaded newer image for ghcr.io/yikun/apache-spark-github-action-image-cache:master-static root3550e09e0e93:/# exit ``` Closes #37402 from Yikun/patch-32. Authored-by: Yikun Jiang <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.