[SPARK-37888][SQL][TESTS] Unify v1 and v2 DESCRIBE TABLE tests
#36912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
DESCRIBE TABLE testsDESCRIBE TABLE tests
Contributor
|
A major problem in #35265 is how to unify the v1 and v2 DESCRIBE TABLE command. I'm OK to unify the tests first, and let's unify the commands in a later PR. |
cloud-fan
approved these changes
Jun 21, 2022
Member
Author
|
Merging to master. Thank you, @cloud-fan for review. |
cloud-fan
reviewed
Jun 30, 2022
| Row("Database", "ns", ""), | ||
| Row("Table", "table", ""), | ||
| Row("Last Access", "UNKNOWN", ""), | ||
| Row("Created By", "Spark 3.4.0-SNAPSHOT", ""), |
Contributor
There was a problem hiding this comment.
we should filter out this row as well, otherwise we need to keep updating this test when making a new release. cc @MaxGekk
Member
Author
There was a problem hiding this comment.
Will do in another PR for DESCRIBE TABLE tests.
Contributor
There was a problem hiding this comment.
Next time, let's address comments immediately. We missed fixing it in the next PR...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DESCRIBE TABLEparsing tests toDescribeRelationParserSuite.DESCRIBE TABLEtests into one traitorg.apache.spark.sql.execution.command.DescribeTableSuiteBase, and put datasource specific tests to thev1.DescribeTableSuiteandv2.DescribeTableSuite.The changes follow the approach of #30287.
Closes #36671.
Why are the changes needed?
DESCRIBE TABLEtests for both DSv1/Hive DSv1 and DSv2Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the modified test suites:
and new test suites: