Skip to content

Conversation

@MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented May 25, 2022

What changes were proposed in this pull request?

  1. Move DESCRIBE TABLE parsing tests to DescribeRelationParserSuite.
  2. Put common DESCRIBE TABLE tests into one trait org.apache.spark.sql.execution.command.DescribeTableSuiteBase, and put datasource specific tests to the v1.DescribeTableSuite and v2.DescribeTableSuite.

The changes follow the approach of #30287.

Closes #35265

Why are the changes needed?

  1. The unification will allow to run common DESCRIBE TABLE tests for both DSv1/Hive DSv1 and DSv2
  2. We can detect missing features and differences between DSv1 and DSv2 implementations.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing unit tests and new tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants