[SPARK-38094][SQL][FOLLOWUP] Fix exception message and add a test case#35700
Closed
jackierwzhang wants to merge 4 commits intoapache:masterfrom
jackierwzhang:SPARK-38094-minor
Closed
[SPARK-38094][SQL][FOLLOWUP] Fix exception message and add a test case#35700jackierwzhang wants to merge 4 commits intoapache:masterfrom jackierwzhang:SPARK-38094-minor
jackierwzhang wants to merge 4 commits intoapache:masterfrom
jackierwzhang:SPARK-38094-minor
Conversation
dongjoon-hyun
changed the title
...e/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
Outdated
Show resolved
Hide resolved
...rc/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFieldIdIOSuite.scala
Outdated
Show resolved
Hide resolved
...rc/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFieldIdIOSuite.scala
Outdated
Show resolved
Hide resolved
sadikovi
approved these changes
Mar 1, 2022
...e/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
approved these changes
Mar 2, 2022
|
Can one of the admins verify this patch? |
...e/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
approved these changes
Mar 2, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (except one minor comment)
Member
|
Merged to master. Thank you, @jackierwzhang . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Minor follow ups on #35385:
Why are the changes needed?
Better observability.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test