Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Dec 24, 2021

What changes were proposed in this pull request?

This reverts commit c0cedb1.

Why are the changes needed?

#35011 changes log level and causes some tests that check log message failed.

Actually #34965 was merged not long ago which fixes logging issue for hive-thriftserver module that produces large log output.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass tests.

@viirya
Copy link
Member Author

viirya commented Dec 24, 2021

cc @gengliangwang @HyukjinKwon

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2021

Codecov Report

Merging #35014 (c0cedb1) into master (c0cedb1) will not change coverage.
The diff coverage is n/a.

❗ Current head c0cedb1 differs from pull request most recent head eb46d81. Consider uploading reports for the commit eb46d81 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #35014   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files         296      296           
  Lines       63198    63198           
  Branches     9888     9888           
=======================================
  Hits        57297    57297           
  Misses       4589     4589           
  Partials     1312     1312           
Flag Coverage Δ
unittests 90.63% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0cedb1...eb46d81. Read the comment docs.

@SparkQA
Copy link

SparkQA commented Dec 24, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51038/

@HyukjinKwon
Copy link
Member

Oops sorry my bad

@HyukjinKwon
Copy link
Member

let me merge this since this is a clean revert

@HyukjinKwon
Copy link
Member

Merged to master.

@HyukjinKwon
Copy link
Member

sorry guys. I had to wait for the test results.

@SparkQA
Copy link

SparkQA commented Dec 24, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51038/

@gengliangwang
Copy link
Member

Late LGTM. Thank you @viirya

@SparkQA
Copy link

SparkQA commented Dec 24, 2021

Test build #146563 has finished for PR 35014 at commit eb46d81.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Dec 24, 2021

thank you @HyukjinKwon @gengliangwang

@viirya viirya deleted the revert-SPARK-37733 branch December 27, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants