Skip to content

Conversation

@gengliangwang
Copy link
Member

What changes were proposed in this pull request?

Change log level of tests to WARN

Why are the changes needed?

After #34895, the log level of tests becomes either "INFO" or "DEBUG", this increases the log output file to over 100MB!
E.g https://github.com/gengliangwang/spark/runs/4623214509?check_suite_focus=true

This makes it difficult to find the CI test failures. Changing the log level of tests to WARN should help.

Does this PR introduce any user-facing change?

No

How was this patch tested?

It's just conf change.

@SparkQA
Copy link

SparkQA commented Dec 24, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51032/

@HyukjinKwon
Copy link
Member

Merged to master.

@SparkQA
Copy link

SparkQA commented Dec 24, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51032/

@SparkQA
Copy link

SparkQA commented Dec 24, 2021

Test build #146557 has finished for PR 35011 at commit 23c962e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Dec 24, 2021

Hmm, changing log level seems causing some test failures, e.g. ShuffleBlockFetcherIteratorSuite which checks some log messages.

@HyukjinKwon @gengliangwang

@viirya
Copy link
Member

viirya commented Dec 24, 2021

Shall we revert this first?

Actually I merged #34965 which fixes logging issue for hive-thriftserver module that produces large log output a few hours ago. I think it already fixes the issue of this PR. The link @gengliangwang attached in the description is happened before.

HyukjinKwon pushed a commit that referenced this pull request Dec 24, 2021
### What changes were proposed in this pull request?

This reverts commit c0cedb1.

### Why are the changes needed?

#35011 changes log level and causes some tests that check log message failed.

Actually #34965 was merged not long ago which fixes logging issue for hive-thriftserver module that produces large log output.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Pass tests.

Closes #35014 from viirya/revert-SPARK-37733.

Authored-by: Liang-Chi Hsieh <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
@HyukjinKwon
Copy link
Member

Sorry guys. it was my bad. I had to wait for the test results. will be careful next time ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants