Skip to content

[SPARK-37084][SQL] Set spark.sql.files.openCostInBytes to bytesConf #34353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RabbidHY wants to merge 2 commits into from
Closed

[SPARK-37084][SQL] Set spark.sql.files.openCostInBytes to bytesConf #34353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6be31f
Set spark.sql.files.openCostInBytes to bytesConf
RabbidHY Oct 21, 2021
4003f0c
Set spark.sql.files.openCostInBytes to bytesConf
RabbidHY Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ class ConfigEntrySuite extends SparkFunSuite {
assert(conf.get(bytes) === 1024L)
conf.set(bytes.key, "1k")
assert(conf.get(bytes) === 1L)
conf.set(bytes.key, "2048")
assert(conf.get(bytes) === 2048)
}

test("conf entry: regex") {
Expand Down
4 changes: 2 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1415,8 +1415,8 @@ object SQLConf {
" bigger files (which is scheduled first). This configuration is effective only when using" +
" file-based sources such as Parquet, JSON and ORC.")
.version("2.0.0")
.longConf
.createWithDefault(4 * 1024 * 1024)
.bytesConf(ByteUnit.BYTE)
.createWithDefaultString("4MB")
Copy link
Member

@HyukjinKwon HyukjinKwon Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a simple test at ConfigEntrySuite to make sure byte configuration is able to take the long type numbers?

Copy link
Contributor

@JoshRosen JoshRosen Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1; we could probably extend this existing test:

spark/core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala

Lines 90 to 97 in 4148fb5

test("conf entry: bytes") {
val conf = new SparkConf()
val bytes = ConfigBuilder(testKey("bytes")).bytesConf(ByteUnit.KiB)
.createWithDefaultString("1m")
assert(conf.get(bytes) === 1024L)
conf.set(bytes.key, "1k")
assert(conf.get(bytes) === 1L)
}


val FILES_MIN_PARTITION_NUM = buildConf("spark.sql.files.minPartitionNum")
.doc("The suggested (not guaranteed) minimum number of split file partitions. " +
Expand Down