[SPARK-37084][SQL] Set spark.sql.files.openCostInBytes to bytesConf #34353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Oct 21, 2021
| .longConf | ||
| .createWithDefault(4 * 1024 * 1024) | ||
| .bytesConf(ByteUnit.BYTE) | ||
| .createWithDefaultString("4MB") |
Member
There was a problem hiding this comment.
Can we add a simple test at ConfigEntrySuite to make sure byte configuration is able to take the long type numbers?
Contributor
There was a problem hiding this comment.
+1; we could probably extend this existing test:
Member
|
Let's also file a JIRA, see also https://spark.apache.org/contributing.html |
RabbidHY
changed the title
wangyum
approved these changes
Oct 22, 2021
Member
|
ok to test |
HyukjinKwon
approved these changes
Oct 23, 2021
Member
|
Merged to master. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #144550 has finished for PR 34353 at commit
|
|
Can one of the admins verify this patch? |
HyukjinKwon
pushed a commit
that referenced
this pull request
Oct 25, 2021
### What changes were proposed in this pull request? Set `spark.sql.files.openCostInBytes` to bytesConf. ### Why are the changes needed? The name is _*InBytes_, but it actually only accepts **long type**. This is confusing for users. After the changes, it can accept **String** as input which is more flexible to users. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing test. Closes #34353 from RabbidHY/SPARK-37084. Authored-by: RabbidHY <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set
spark.sql.files.openCostInBytesto bytesConf.Why are the changes needed?
The name is *InBytes, but it actually only accepts long type. This is confusing for users. After the changes, it can accept String as input which is more flexible to users.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test.