Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a minor followup of #33992 to fix the warnings during PySpark documentation build:

/.../spark/python/pyspark/sql/functions.py:docstring of pyspark.sql.functions.bit_length:19: WARNING: Unexpected section title or transition.

-------
/.../spark/python/pyspark/sql/functions.py:docstring of pyspark.sql.functions.octet_length:19: WARNING: Unexpected section title or transition.

-------

We should always have the same length of hyphens with the title.

Why are the changes needed?

To remove warnings during the documentation build and show the HTML pages correctly.

Does this PR introduce any user-facing change?

This is not released yet, and only in master branch. So, no to end users.

How was this patch tested?

Manually built the docs via make clean html at python/docs directory.

@HyukjinKwon
Copy link
Member Author

cc @sarutak and @yoda-mon FYI

@SparkQA
Copy link

SparkQA commented Oct 6, 2021

Test build #143875 has finished for PR 34196 at commit 47f43fc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 6, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48388/

@SparkQA
Copy link

SparkQA commented Oct 6, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48388/

Copy link
Member

@sarutak sarutak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HyukjinKwon . I noticed the layout of the examples is broken too.
Can we fix them within this PR?
octet_length_strange_example_layout

Otherwise, It LGTM.

@HyukjinKwon
Copy link
Member Author

Thanks man!

@SparkQA
Copy link

SparkQA commented Oct 6, 2021

Test build #143881 has finished for PR 34196 at commit a7bf0e0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 6, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48394/

@sarutak sarutak closed this in 2953d4f Oct 6, 2021
@sarutak
Copy link
Member

sarutak commented Oct 6, 2021

@HyukjinKwon Thank you for following up! Merged to master.

@SparkQA
Copy link

SparkQA commented Oct 6, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48394/

@HyukjinKwon HyukjinKwon deleted the SPARK-36751 branch January 4, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants