Skip to content

[SPARK-4553][SQL] Query for parquet table with string fields in spark sql hive get binary result #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scwf wants to merge 7 commits into from
Closed

[SPARK-4553][SQL] Query for parquet table with string fields in spark sql hive get binary result #3414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5f5fda8
https -> http in pom
scwf Nov 17, 2014
626f72b
fix parquet string issue for hive
scwf Nov 18, 2014
1fd70e8
Revert "https -> http in pom"
scwf Nov 18, 2014
3ae93c5
Merge branch 'master' into parquet-hive
scwf Nov 18, 2014
2e04cd3
minor fix
scwf Nov 22, 2014
d563124
fix test case
scwf Nov 22, 2014
9c85c22
address comment
scwf Nov 25, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,14 @@ class HiveContext(sc: SparkContext) extends SQLContext(sc) {
private[spark] def convertMetastoreParquet: Boolean =
getConf("spark.sql.hive.convertMetastoreParquet", "true") == "true"

private[spark] def parquetBinaryAsString = setConf("spark.sql.parquet.binaryAsString", "true")
Copy link
Contributor

@marmbrus marmbrus Dec 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be mutating configuration when accessing a setting. Also, I think that #3441 is going to solve this problem so perhaps we can close this issue?


// Hive use parquet with older version, which do not differentiate between binary data and strings
// So here set spark.sql.parquet.binaryAsString to true
if (convertMetastoreParquet) {
parquetBinaryAsString
}

override protected[sql] def executePlan(plan: LogicalPlan): this.QueryExecution =
new this.QueryExecution { val logical = plan }

Expand Down
7 changes: 7 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/parquet/HiveParquetSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,13 @@ class HiveParquetSuite extends FunSuite with BeforeAndAfterAll with BeforeAndAft
compareRDDs(rddOrig, rddCopy, "testsource", ParquetTestData.testSchemaFieldNames)
}

test("SPARK-4553: String issue for Parquet Table") {
sql("CREATE TABLE parquet_string(key INT, value STRING)")
sql("INSERT OVERWRITE TABLE parquet_string SELECT * FROM src")
val result = sql("SELECT * FROM parquet_string limit 5").collect
assert(result(0)(1).isInstanceOf[String])
}

private def compareRDDs(rddOne: Array[Row], rddTwo: Array[Row], tableName: String, fieldNames: Seq[String]) {
var counter = 0
(rddOne, rddTwo).zipped.foreach {
Expand Down